Only register directories for watching

[vandenoever]

Directories also report the events for the files in the directories.

[passcod]

Walk me through this. What does your change do? Does it still support calling add_watch_recursively on a file?

[vandenoever]

For normal files there is no need for a watch, so for files instead of calling add_watch, Ok(()) is returned.

[vandenoever]

I see now that this patch does not yet support calling add_watch_recursively to register a watch on a single file.

[passcod]

This function originally has two scenarios:

• If Path is a file, watch it
• If Path is a dir, watch dir, all subdirs and subfiles

We want:

• If Path is a file, watch it
• If Path is a dir, watch dir and all subdirs only

Your patch does, even the updated version:

• If Path is a file, fail silently
• If Path is a dir, watch dir, all subdirs and subfiles

So, see, what your patch does is silently break a valid use case, and fail to actually address the problem.

[vandenoever]

I uploaded a new diff in pull request #76 . I'm on a very bad connection and have a hard time updating the diff on this PR.

Update: I managed to update PR #74 and will close PR #76