Fix possible instant subtraction panic racing the clock#182
Merged
passcod merged 1 commit intonotify-rs:mainfrom Feb 19, 2019
Merged
Fix possible instant subtraction panic racing the clock#182passcod merged 1 commit intonotify-rs:mainfrom
passcod merged 1 commit intonotify-rs:mainfrom
Conversation
Member
|
Great find! |
|
Would appreciate a bugfix release with this fix :) |
Member
|
Done in 4.0.10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got a panic that I found difficult to reproduce reliably.
Instantsubtractions will panic if the rhs is bigger, and two calls ofInstant::nowmay be different. So its sort of a race with the clock to see if this panics.