Poll backend: Release the lock while we sleep.#159
Merged
passcod merged 1 commit intonotify-rs:masterfrom Aug 5, 2018
Merged
Conversation
If we sleep while holding the lock, we can block calls to watch().
|
Looks like the OSX errors are legit? |
Contributor
Author
|
They don't look related to this commit, same failures are seen in the last master CI run. |
Member
|
Thanks for this, looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we sleep while holding the lock, we can block calls to watch().
Seeing this on FreeBSD, where even the most trivial example program will randomly hang while setting up watches.