Add FsEventWatcher Support. fix #7#13
Conversation
|
I'm going to leave this to @octplane to evaluate and decide if it's mergeable or if some of it should be split back to fsevent-rust. I'd also like to have watch and unwatch working completely before merging, unless y'all think that's too much work. |
|
:) done. |
|
@octplane if some of this should be split back to fsevent-rust? |
|
LGTM. I will probably later remove some code from here to avoid duplication with my binding, but is seems reasonable to merge as-is if it is working correctly :). Great job @andelf! |
|
@andelf: yes ! your comment arrived while I was writing mine :) |
|
Leave the Watcher open for further |
|
I'll probably merge in either a few hours, or tomorrow. Thanks both for the great work! |
|
Comments in the code are minor style nitpicks, ignore them; I'll fix in the merge. |
There was a problem hiding this comment.
This should probably be a Result<(), String>
This is ispired by the original work of https://github.com/octplane/fsevent-rust .
Currently you can only call.watch()once, and.unwatch()left unimplemented.Good news is that
Dropworks. :)UPDATE:
.watch().unwatch()works.r: #12 #7
@octplane