fix: export types mistakenly left private#27
Merged
TomAFrench merged 19 commits intomainfrom Jan 9, 2025
Merged
Conversation
TomAFrench
requested changes
Jan 8, 2025
Member
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
We don't need to bump the minimum supported noir version for this.
Also remember that PR titles end up going into the release changelog so something like "fix: export types mistakenly left private" would be much more useful for users compared to "fix: nightly support"
Contributor
Author
|
we have to wait until I fix noir-sort and a release to be made for this PR to be merged |
Contributor
Author
|
@TomAFrench do we need to test against 0.34.0 and 0.35.0 still? |
TomAFrench
reviewed
Jan 8, 2025
TomAFrench
reviewed
Jan 8, 2025
kashbrti
changed the title
TomAFrench
reviewed
Jan 9, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.