Skip to content

fix: add type declarations to globals#21

Merged
TomAFrench merged 2 commits intomainfrom
kh/fix_nightly
Nov 25, 2024
Merged

fix: add type declarations to globals#21
TomAFrench merged 2 commits intomainfrom
kh/fix_nightly

Conversation

@kashbrti
Copy link
Contributor

@kashbrti kashbrti commented Nov 25, 2024

Description

globals are now required to have their types specified.
There were a bunch of them in the lib that didn't.

Problem*

Resolves

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kashbrti kashbrti requested a review from TomAFrench November 25, 2024 10:23
@TomAFrench TomAFrench changed the title fix: fixed tests failing with latest nightly fix: add type declarations to globals Nov 25, 2024
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomAFrench TomAFrench merged commit c32dcd5 into main Nov 25, 2024
@TomAFrench TomAFrench deleted the kh/fix_nightly branch November 25, 2024 10:38
@github-actions github-actions bot mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants