Skip to content

chore!: replace fixed size JSON modules with type aliases#19

Merged
TomAFrench merged 1 commit intomainfrom
tf/type-aliases
Jan 8, 2025
Merged

chore!: replace fixed size JSON modules with type aliases#19
TomAFrench merged 1 commit intomainfrom
tf/type-aliases

Conversation

@TomAFrench
Copy link
Member

Description

Problem*

Resolves #10

Summary*

This replaces a load of duplicated code with proper type aliases.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from kashbrti November 8, 2024 02:27
@TomAFrench TomAFrench mentioned this pull request Jan 8, 2025
2 tasks
@TomAFrench
Copy link
Member Author

@kashbrti

Copy link
Contributor

@kashbrti kashbrti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomAFrench TomAFrench merged commit e5669b6 into main Jan 8, 2025
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modules named JSON512b, JSON1kb, etc. should be replaced with type aliases.

2 participants