Merged
Conversation
Contributor
Author
|
I'm failing to run the formatter. Here's the error I'm getting. It's a bit weird that it panics because I can compile and also the tests pass. |
5 tasks
github-merge-queue bot
pushed a commit
to noir-lang/noir
that referenced
this pull request
Oct 24, 2024
# Description ## Problem Resolves noir-lang/noir_json_parser#16 (comment) ## Summary I thought for "op assign" like `x += 1` there will always come one or two tokens, then `=`, but that's not the case for `>>=` (it's `> >=`). ## Additional Context ## Documentation Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Member
|
|
2 tasks
Contributor
|
Right, I made some changes to the formatter after 0.36.0 was released because otherwise it destroyed all the formatting that exists in the array literals here. |
Contributor
Author
|
I think it works with nightly just not with 0.36.0. should we just go ahead and merge this? |
TomAFrench
reviewed
Oct 31, 2024
Member
|
It'll need the formatter to be disabled first if we're going to merge without it. |
TomAFrench
approved these changes
Nov 6, 2024
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixed the issues with the new release
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.