fix: variable used in fmtstr inside lambda wasn't tracked as captured#8487
Merged
fix: variable used in fmtstr inside lambda wasn't tracked as captured#8487
Conversation
jfecher
approved these changes
May 13, 2025
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 14, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix: pass Field to ToBits intrinsic in remove_bit_shifts optimization (noir-lang/noir#8493) fix: don't produce `index Field` in value merger (noir-lang/noir#8492) fix: allowing accessing associated constants via `Self::...` (noir-lang/noir#8403) fix: remove unused generic in static_assert (noir-lang/noir#8488) fix: disallow generics on entry points (noir-lang/noir#8490) chore(test): Replicate comptime stack overflow in a test (noir-lang/noir#8473) feat: `#[test(only_fail_with = "...")]` (noir-lang/noir#8460) fix: variable used in fmtstr inside lambda wasn't tracked as captured (noir-lang/noir#8487) chore(test): Add more tests for defunctionalization (noir-lang/noir#8481) END_COMMIT_OVERRIDE Co-authored-by: AztecBot <tech@aztecprotocol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Resolves #8166
Summary
We were missing a similar treatment to what we do with local variables, but when elaborating format string interpolated identifiers.
I didn't know what name to use for the extracted logic, I went with
handle_hir_identbut happy to give it a better name.Additional Context
Documentation
Check one:
PR Checklist
cargo fmton default settings.