Skip to content

Commit cfad664

Browse files
chore: test ACVM BigInt (#5559)
# Description ## Problem\* Part of #5426 ## Summary\* Tests - Conversion to/from LE arrays of bytes - Add/Mul associative/commutative/identity - Mul has L/R zero - Distributive property - Invertibility of Add/Mul - Injectivity of Add ## Additional Context Without updating `overflow-checks` defaults, the invalid-modulus only panics locally while passing in CI. It results in a 22% increase in user time and 27% increase in wall-clock time running `cargo test` (in release mode): - With overflow checks: `708.25s user 38.29s system 842% cpu 1:28.65 total` - Without overflow checks: `577.09s user 32.65s system 875% cpu 1:09.68 total` ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
1 parent a764c5b commit cfad664

2,402 files changed

Lines changed: 10741 additions & 17 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

Cargo.toml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,14 @@ rust-embed = "6.6.0"
166166
# See https://ritik-mishra.medium.com/resolving-the-wasm-pack-error-locals-exceed-maximum-ec3a9d96685b
167167
opt-level = 1
168168

169+
# release mode with extra checks, e.g. overflow checks
170+
[profile.release-pedantic]
171+
inherits = "release"
172+
overflow-checks = true
173+
174+
[profile.test]
175+
inherits = "dev"
176+
overflow-checks = true
169177

170178
[profile.size]
171179
inherits = "release"

acvm-repo/acvm/Cargo.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ repository.workspace = true
1313
[lints]
1414
workspace = true
1515

16-
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
17-
1816
[dependencies]
1917
num-bigint.workspace = true
2018
thiserror.workspace = true

0 commit comments

Comments
 (0)