feat(tls.createSecureContext): introduce

[0hmX]

closes: #123

[AugustinMauroy]

Minor thing

[brunocroh]

You did a great job on that, thank you for your awesome contribution!

I have some comments on a few points, feel free to share your opinion if you don't agree with something.

And just one more thing: could you please check if you ran node --run pre-commit? I think there are some Biome rules that aren't applied.

[AugustinMauroy]

LGMT ! Thanks for you first contribution.
If you have any feedback about DX on this project let's me know. And if you have any feedback about codemod CLI/platform I'm going to transfer it to them

[AugustinMauroy]

fro windows failing use https://nodejs.org/api/os.html#oseol instead of \n

[AugustinMauroy]

we also have few utility you should use it to simplify

[JakobJingleheimer]

Okay, so I ended up rewriting the code, but it's now bigger than the previous version🫠. Yes, I am using the utilities. I added a few more test cases related to pair_pattern and import_specifier.

However, I couldn't get the logic to work for const createCredentials = (await import('node:crypto')).then((m) => m.createCredentials) because the getNodeImportCalls utility does not handle this case. I want to skip it, as adding the extra code would make the file too large.

Thanks! I'm sure it was a fair amount of work 😅 (that's why I said it wasn't necessarily a blocker)

Unfortunately you force-pushed, which wipes the review history. That means the entire PR has to get reviewed again instead of just the pieces recently changed (and that massively increases the effort & time needed to review the latest changes). I've updated the repo settings to now block force-pushing to prevent this happening again (you weren't the only one to do it), but FYI the next review will take me some time to get through now because of that force-push 😬

[AugustinMauroy]

LGMT !

[JakobJingleheimer]

LGTM :)

PS Sorry it took me a while to get back to this.

[AugustinMauroy]

hey @0hmX any news on this pr ?

[JakobJingleheimer]

@0hmX did you intend to close this? O.o it's ready to go

[AugustinMauroy]

I'm going to take over this pr so we can land it

[brunocroh]

@AugustinMauroy CI here is failing

[brunocroh]

LGTM