multiple codemod same time

Author: AugustinMauroy

utils/src/logger.test.ts

@@ -92,4 +92,38 @@ describe('logger', { concurrency: true }, () => {
 		t.assert.snapshot(stdout);
 		assert.equal(code, 0);
 	});
+
+	it('should handle multiple codemods with different names correctly', async () => {
+		const { code, stdout } = await spawnPromisified(
+			execPath,
+			[
+				'--no-warnings',
+				'--experimental-strip-types',
+				'-e',
+				dedent`
+				import { logger, setCodemodName } from './logger.ts';
+
+				// Simulate first codemod
+				setCodemodName('codemod-a');
+				logger('/tmp/file1.js', 'log', 'Message from codemod A');
+
+				// Simulate second codemod (this would previously overwrite the name)
+				logger('/tmp/file2.js', 'log', 'Message from codemod B', 'codemod-b');
+
+				// Another message from first codemod (should still show as codemod-a)
+				logger('/tmp/file3.js', 'log', 'Another message from codemod A');
+			`,
+			],
+			{
+				cwd: import.meta.dirname,
+			},
+		);
+
+		// Should show both codemod names in output
+		assert(stdout.includes('[Codemod: codemod-a]'));
+		assert(stdout.includes('[Codemod: codemod-b]'));
+		assert(stdout.includes('Message from codemod A'));
+		assert(stdout.includes('Message from codemod B'));
+		assert.equal(code, 0);
+	});
 });

utils/src/logger.ts

@@ -2,25 +2,26 @@ import process from 'node:process';
 
 type LogMsg = string;
 type LogType = 'error' | 'log' | 'warn';
-type FileLog = { msg: LogMsg; type: LogType };
+type FileLog = { msg: LogMsg; type: LogType; codemodName: string };
 type Source = URL['pathname'];
 
-let codemodName = 'nodjs-codemod';
+let defaultCodemodName = 'nodjs-codemod';
 
 /**
- * Set the codemod name for logging output
+ * Set the default codemod name for logging output
  */
 export const setCodemodName = (name: string) => {
-    codemodName = name;
+    defaultCodemodName = name;
 };
 
 /**
  * Collect log entries and report them at the end, collated by source module.
  */
-export const logger = (source: Source, type: LogType, msg: LogMsg) => {
+export const logger = (source: Source, type: LogType, msg: LogMsg, codemodName?: string) => {
+    const name = codemodName ?? defaultCodemodName;
     const fileLog = new Set<FileLog>(logs.has(source) ? logs.get(source) : []);
 
-    fileLog.add({ msg, type });
+    fileLog.add({ msg, type, codemodName: name });
     logs.set(source, fileLog);
 };
 
@@ -34,19 +35,45 @@ process.once('beforeExit', emitLogs);
 function emitLogs() {
     let hasError = false;
 
-    for (const [sourceFile, fileLog] of logs.entries()) {
-        console.log(`[Codemod: ${codemodName}]:`, sourceFile);
-        for (const { msg, type } of fileLog) {
-            console[type](' •', msg);
-            if (type === 'error') hasError = true;
+    // Group logs by codemod name first, then by source file
+    const logsByCodemod = new Map<string, Map<Source, Set<FileLog>>>();
+
+    for (const [sourceFile, fileLogs] of logs.entries()) {
+        for (const fileLog of fileLogs) {
+            if (!logsByCodemod.has(fileLog.codemodName)) {
+                logsByCodemod.set(fileLog.codemodName, new Map());
+            }
+            const codemodLogs = logsByCodemod.get(fileLog.codemodName)!;
+            if (!codemodLogs.has(sourceFile)) {
+                codemodLogs.set(sourceFile, new Set());
+            }
+            codemodLogs.get(sourceFile)!.add(fileLog);
         }
     }
 
-    if (hasError) {
-        console.error(`[Codemod: ${codemodName}]: migration incomplete!`);
-        process.exitCode = 1;
-    } else {
-        process.exitCode = 0;
-        console.log(`[Codemod: ${codemodName}]: migration complete!`);
+    for (const [codemodName, codemodLogs] of logsByCodemod.entries()) {
+        for (const [sourceFile, fileLogs] of codemodLogs.entries()) {
+            console.log(`[Codemod: ${codemodName}]:`, sourceFile);
+            for (const { msg, type } of fileLogs) {
+                console[type](' •', msg);
+                if (type === 'error') hasError = true;
+            }
+        }
+
+        if (hasError) {
+            console.error(`[Codemod: ${codemodName}]: migration incomplete!`);
+        } else {
+            console.log(`[Codemod: ${codemodName}]: migration complete!`);
+        }
+        hasError = false; // Reset for next codemod
     }
+
+    // Set overall exit code based on any errors
+    process.exitCode = Array.from(logsByCodemod.values())
+        .some(codemodLogs =>
+            Array.from(codemodLogs.values())
+                .some(fileLogs =>
+                    Array.from(fileLogs).some(log => log.type === 'error')
+                )
+        ) ? 1 : 0;
 }