From d9fef984a8340f8e97eb8580bfb8eab00ce406da Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Thu, 7 Nov 2024 12:04:06 +0000 Subject: [PATCH 1/2] Skip debuglog tests Signed-off-by: Matteo Collina --- test/node-test/debug.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test/node-test/debug.js b/test/node-test/debug.js index bd4d3e806fe..9bac9683c8f 100644 --- a/test/node-test/debug.js +++ b/test/node-test/debug.js @@ -8,9 +8,10 @@ const { tspl } = require('@matteo.collina/tspl') // eslint-disable-next-line no-control-regex const removeEscapeColorsRE = /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/g +const isNode23Plus = process.versions.node.split('.')[0] >= 23 const isCITGM = !!process.env.CITGM -test('debug#websocket', { skip: !process.versions.icu || isCITGM }, async t => { +test('debug#websocket', { skip: !process.versions.icu || isCITGM || isNode23Plus }, async t => { const assert = tspl(t, { plan: 6 }) const child = spawn( process.execPath, @@ -39,6 +40,7 @@ test('debug#websocket', { skip: !process.versions.icu || isCITGM }, async t => { }) child.stderr.on('end', () => { const lines = extractLines(chunks) + console.log(lines) assert.strictEqual(lines.length, assertions.length) for (let i = 1; i < lines.length; i++) { assert.match(lines[i], assertions[i]) @@ -48,7 +50,7 @@ test('debug#websocket', { skip: !process.versions.icu || isCITGM }, async t => { await assert.completed }) -test('debug#fetch', { skip: isCITGM }, async t => { +test('debug#fetch', { skip: isCITGM || isNode23Plus }, async t => { const assert = tspl(t, { plan: 7 }) const child = spawn( process.execPath, @@ -85,7 +87,7 @@ test('debug#fetch', { skip: isCITGM }, async t => { await assert.completed }) -test('debug#undici', { skip: isCITGM }, async t => { +test('debug#undici', { skip: isCITGM || isNode23Plus }, async t => { // Due to Node.js webpage redirect const assert = tspl(t, { plan: 7 }) const child = spawn( From aaa9b73dae048e1f64705e6827d4635352be31af Mon Sep 17 00:00:00 2001 From: Aras Abbasi Date: Thu, 7 Nov 2024 14:09:00 +0100 Subject: [PATCH 2/2] Update test/node-test/debug.js --- test/node-test/debug.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/node-test/debug.js b/test/node-test/debug.js index 9bac9683c8f..f85dff58cf9 100644 --- a/test/node-test/debug.js +++ b/test/node-test/debug.js @@ -40,7 +40,6 @@ test('debug#websocket', { skip: !process.versions.icu || isCITGM || isNode23Plus }) child.stderr.on('end', () => { const lines = extractLines(chunks) - console.log(lines) assert.strictEqual(lines.length, assertions.length) for (let i = 1; i < lines.length; i++) { assert.match(lines[i], assertions[i])