Skip to content

Commit eadf781

Browse files
authored
websocket: don't clone buffer (#3240)
* websocket: don't clone buffer * Apply suggestions from code review * fixup * Apply suggestions from code review
1 parent f744596 commit eadf781

File tree

2 files changed

+1
-37
lines changed

2 files changed

+1
-37
lines changed

lib/web/websocket/websocket.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ class WebSocket extends EventTarget {
287287
// not throw an exception must increase the bufferedAmount attribute
288288
// by the length of data’s buffer in bytes.
289289

290-
const ab = new FastBuffer(data, data.byteOffset, data.byteLength)
290+
const ab = new FastBuffer(data.buffer, data.byteOffset, data.byteLength)
291291

292292
const frame = new WebsocketFrameSend(ab)
293293
const buffer = frame.createFrame(opcodes.BINARY)

test/wpt/status/websockets.status.json

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -16,42 +16,6 @@
1616
}
1717
}
1818
},
19-
"Send-binary-arraybufferview-float32.any.js": {
20-
"note": "TODO(@KhafraDev): investigate failure",
21-
"fail": [
22-
"Send binary data on a WebSocket - ArrayBufferView - Float32Array - Connection should be closed"
23-
]
24-
},
25-
"Send-binary-arraybufferview-float64.any.js": {
26-
"note": "TODO(@KhafraDev): investigate failure",
27-
"fail": [
28-
"Send binary data on a WebSocket - ArrayBufferView - Float64Array - Connection should be closed"
29-
]
30-
},
31-
"Send-binary-arraybufferview-int16-offset.any.js": {
32-
"note": "TODO(@KhafraDev): investigate failure",
33-
"fail": [
34-
"Send binary data on a WebSocket - ArrayBufferView - Int16Array with offset - Connection should be closed"
35-
]
36-
},
37-
"Send-binary-arraybufferview-int32.any.js": {
38-
"note": "TODO(@KhafraDev): investigate failure",
39-
"fail": [
40-
"Send binary data on a WebSocket - ArrayBufferView - Int32Array - Connection should be closed"
41-
]
42-
},
43-
"Send-binary-arraybufferview-uint16-offset-length.any.js": {
44-
"note": "TODO(@KhafraDev): investigate failure",
45-
"fail": [
46-
"Send binary data on a WebSocket - ArrayBufferView - Uint16Array with offset and length - Connection should be closed"
47-
]
48-
},
49-
"Send-binary-arraybufferview-uint32-offset.any.js": {
50-
"note": "TODO(@KhafraDev): investigate failure",
51-
"fail": [
52-
"Send binary data on a WebSocket - ArrayBufferView - Uint32Array with offset - Connection should be closed"
53-
]
54-
},
5519
"Create-on-worker-shutdown.any.js": {
5620
"skip": true,
5721
"//": "Node.js workers are different from web workers & don't work with blob: urls"

0 commit comments

Comments
 (0)