Skip to content

Commit da7e78b

Browse files
metcoder95metcoder95
committed
ci: isolate windows
1 parent 48f4546 commit da7e78b

File tree

2 files changed

+129
-128
lines changed

2 files changed

+129
-128
lines changed

‎.github/workflows/nodejs.yml‎

Lines changed: 114 additions & 114 deletions
Original file line numberDiff line numberDiff line change
@@ -62,136 +62,136 @@ jobs:
6262
- 22
6363
- 23
6464
runs-on:
65-
- ubuntu-latest
65+
# - ubuntu-latest
6666
- windows-latest
67-
- macos-latest
67+
# - macos-latest
6868
uses: ./.github/workflows/test.yml
6969
with:
7070
node-version: ${{ matrix.node-version }}
7171
runs-on: ${{ matrix.runs-on }}
7272
secrets: inherit
7373

74-
test-without-intl:
75-
name: Test with Node.js ${{ matrix.version }} compiled --without-intl
76-
strategy:
77-
fail-fast: false
78-
max-parallel: 0
79-
matrix:
80-
version: [20, 22, 23]
81-
runs-on: ubuntu-latest
82-
timeout-minutes: 120
83-
steps:
84-
- name: Checkout
85-
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
86-
with:
87-
persist-credentials: false
88-
89-
# Setup node, install deps, and build undici prior to building icu-less node and testing
90-
- name: Setup Node.js@${{ inputs.version }}
91-
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
92-
with:
93-
node-version: ${{ inputs.version }}
94-
95-
- name: Install dependencies
96-
run: npm install
97-
98-
- name: Build undici
99-
run: npm run build:node
100-
101-
- name: Determine latest release
102-
id: release
103-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
104-
with:
105-
result-encoding: string
106-
script: |
107-
const req = await fetch('https://nodejs.org/download/release/index.json')
108-
const releases = await req.json()
109-
110-
const latest = releases.find((r) => r.version.startsWith('v${{ matrix.version }}'))
111-
return latest.version
112-
113-
- name: Download and extract source
114-
run: curl https://nodejs.org/download/release/${{ steps.release.outputs.result }}/node-${{ steps.release.outputs.result }}.tar.xz | tar xfJ -
115-
116-
- name: Install ninja
117-
run: sudo apt-get install ninja-build
118-
119-
- name: ccache
120-
uses: hendrikmuhs/ccache-action@ed74d11c0b343532753ecead8a951bb09bb34bc9 #v1.2.14
121-
with:
122-
key: node${{ matrix.version }}
123-
124-
- name: Build node
125-
working-directory: ./node-${{ steps.release.outputs.result }}
126-
run: |
127-
export CC="ccache gcc"
128-
export CXX="ccache g++"
129-
./configure --without-intl --ninja --prefix=./final
130-
make
131-
make install
132-
echo "$(pwd)/final/bin" >> $GITHUB_PATH
133-
134-
- name: Print version information
135-
run: |
136-
echo OS: $(node -p "os.version()")
137-
echo Node.js: $(node --version)
138-
echo npm: $(npm --version)
139-
echo git: $(git --version)
140-
echo icu config: $(node -e "console.log(process.config)" | grep icu)
141-
142-
- name: Run tests
143-
run: npm run test:javascript:without-intl
144-
145-
test-fuzzing:
146-
name: Fuzzing
147-
runs-on: ubuntu-latest
148-
steps:
149-
- name: Checkout
150-
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
151-
with:
152-
persist-credentials: false
153-
154-
- name: Setup Node.js
155-
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
156-
with:
157-
node-version: lts/*
158-
159-
- name: Install dependencies
160-
run: npm install
161-
162-
- name: Run fuzzing tests
163-
run: npm run test:fuzzing
164-
165-
test-types:
166-
name: Test TypeScript types
167-
timeout-minutes: 15
168-
runs-on: ubuntu-latest
169-
steps:
170-
- name: Checkout
171-
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
172-
with:
173-
persist-credentials: false
174-
175-
- name: Setup Node.js
176-
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
177-
with:
178-
node-version: lts/*
74+
# test-without-intl:
75+
# name: Test with Node.js ${{ matrix.version }} compiled --without-intl
76+
# strategy:
77+
# fail-fast: false
78+
# max-parallel: 0
79+
# matrix:
80+
# version: [20, 22, 23]
81+
# runs-on: ubuntu-latest
82+
# timeout-minutes: 120
83+
# steps:
84+
# - name: Checkout
85+
# uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
86+
# with:
87+
# persist-credentials: false
88+
89+
# # Setup node, install deps, and build undici prior to building icu-less node and testing
90+
# - name: Setup Node.js@${{ inputs.version }}
91+
# uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
92+
# with:
93+
# node-version: ${{ inputs.version }}
94+
95+
# - name: Install dependencies
96+
# run: npm install
97+
98+
# - name: Build undici
99+
# run: npm run build:node
100+
101+
# - name: Determine latest release
102+
# id: release
103+
# uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
104+
# with:
105+
# result-encoding: string
106+
# script: |
107+
# const req = await fetch('https://nodejs.org/download/release/index.json')
108+
# const releases = await req.json()
109+
110+
# const latest = releases.find((r) => r.version.startsWith('v${{ matrix.version }}'))
111+
# return latest.version
112+
113+
# - name: Download and extract source
114+
# run: curl https://nodejs.org/download/release/${{ steps.release.outputs.result }}/node-${{ steps.release.outputs.result }}.tar.xz | tar xfJ -
115+
116+
# - name: Install ninja
117+
# run: sudo apt-get install ninja-build
118+
119+
# - name: ccache
120+
# uses: hendrikmuhs/ccache-action@ed74d11c0b343532753ecead8a951bb09bb34bc9 #v1.2.14
121+
# with:
122+
# key: node${{ matrix.version }}
123+
124+
# - name: Build node
125+
# working-directory: ./node-${{ steps.release.outputs.result }}
126+
# run: |
127+
# export CC="ccache gcc"
128+
# export CXX="ccache g++"
129+
# ./configure --without-intl --ninja --prefix=./final
130+
# make
131+
# make install
132+
# echo "$(pwd)/final/bin" >> $GITHUB_PATH
133+
134+
# - name: Print version information
135+
# run: |
136+
# echo OS: $(node -p "os.version()")
137+
# echo Node.js: $(node --version)
138+
# echo npm: $(npm --version)
139+
# echo git: $(git --version)
140+
# echo icu config: $(node -e "console.log(process.config)" | grep icu)
141+
142+
# - name: Run tests
143+
# run: npm run test:javascript:without-intl
144+
145+
# test-fuzzing:
146+
# name: Fuzzing
147+
# runs-on: ubuntu-latest
148+
# steps:
149+
# - name: Checkout
150+
# uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
151+
# with:
152+
# persist-credentials: false
153+
154+
# - name: Setup Node.js
155+
# uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
156+
# with:
157+
# node-version: lts/*
158+
159+
# - name: Install dependencies
160+
# run: npm install
161+
162+
# - name: Run fuzzing tests
163+
# run: npm run test:fuzzing
164+
165+
# test-types:
166+
# name: Test TypeScript types
167+
# timeout-minutes: 15
168+
# runs-on: ubuntu-latest
169+
# steps:
170+
# - name: Checkout
171+
# uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
172+
# with:
173+
# persist-credentials: false
174+
175+
# - name: Setup Node.js
176+
# uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
177+
# with:
178+
# node-version: lts/*
179179

180-
- name: Install dependencies
181-
run: npm install
180+
# - name: Install dependencies
181+
# run: npm install
182182

183-
- name: Run typings tests
184-
run: npm run test:typescript
183+
# - name: Run typings tests
184+
# run: npm run test:typescript
185185

186186
automerge:
187187
if: >
188188
github.event_name == 'pull_request' && github.event.pull_request.user.login == 'dependabot[bot]'
189189
needs:
190190
- dependency-review
191191
- test
192-
- test-types
193-
- test-without-intl
194-
- test-fuzzing
192+
# - test-types
193+
# - test-without-intl
194+
# - test-fuzzing
195195
- lint
196196
runs-on: ubuntu-latest
197197
permissions:

‎.github/workflows/test.yml‎

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99
runs-on:
1010
required: true
1111
type: string
12+
pull_request:
1213

1314
permissions:
1415
contents: read
@@ -43,22 +44,22 @@ jobs:
4344
run: npm ls --all
4445
continue-on-error: true
4546

46-
- name: Run tests with coverage
47-
id: coverage
48-
if: inputs.runs-on == 'ubuntu-latest' && inputs.node-version == 22
49-
run: npm run coverage:ci
50-
env:
51-
CI: true
52-
NODE_V8_COVERAGE: ./coverage/tmp
47+
# - name: Run tests with coverage
48+
# id: coverage
49+
# if: inputs.runs-on == 'ubuntu-latest' && inputs.node-version == 22
50+
# run: npm run coverage:ci
51+
# env:
52+
# CI: true
53+
# NODE_V8_COVERAGE: ./coverage/tmp
5354

5455
- name: Run tests
55-
if: steps.coverage.outcome == 'skipped'
56-
run: npm run test:javascript
56+
# if: steps.coverage.outcome == 'skipped'
57+
run: npm run test:h2:core -- --only
5758
env:
5859
CI: true
5960

60-
- name: Coverage Report
61-
if: inputs.runs-on == 'ubuntu-latest' && inputs.node-version == 20
62-
uses: codecov/codecov-action@b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238 # v4.6.0
63-
with:
64-
token: ${{ secrets.CODECOV_TOKEN }}
61+
# - name: Coverage Report
62+
# if: inputs.runs-on == 'ubuntu-latest' && inputs.node-version == 20
63+
# uses: codecov/codecov-action@b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238 # v4.6.0
64+
# with:
65+
# token: ${{ secrets.CODECOV_TOKEN }}

0 commit comments

Comments
 (0)