Skip to content

Commit 735558b

Browse files
committed
fix: Fix retry-handler.js when retry-after header is a Date
1 parent 6bb527e commit 735558b

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/handler/retry-handler.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ class RetryHandler {
124124
if (retryAfterHeader) {
125125
retryAfterHeader = Number(retryAfterHeader)
126126
retryAfterHeader = Number.isNaN(retryAfterHeader)
127-
? calculateRetryAfterHeader(retryAfterHeader)
127+
? calculateRetryAfterHeader(headers['retry-after'])
128128
: retryAfterHeader * 1e3 // Retry-After is in seconds
129129
}
130130

test/retry-handler.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -364,19 +364,19 @@ test('Should use retry-after header for retries (date)', async t => {
364364
server.on('request', (req, res) => {
365365
switch (counter) {
366366
case 0:
367+
checkpoint = Date.now()
367368
res.writeHead(429, {
368369
'retry-after': new Date(
369-
new Date().setSeconds(new Date().getSeconds() + 1)
370+
new Date(checkpoint).setSeconds(new Date(checkpoint).getSeconds() + 2)
370371
).toUTCString()
371372
})
372373
res.end('rate limit')
373-
checkpoint = Date.now()
374374
counter++
375375
return
376376
case 1:
377377
res.writeHead(200)
378378
res.end('hello world!')
379-
t.ok(Date.now() - checkpoint >= 1)
379+
t.ok(Date.now() - checkpoint >= 1000)
380380
counter++
381381
return
382382
default:

0 commit comments

Comments
 (0)