web: mark as uncloneable when possible (#3709)

* web: mark as uncloneable when possible

This tells node that the marked instances from undici are not cloneable,
so that attempts to cloning those throw `DataCloneError`.

* test: add test cases for platform objects uncloneable

* fix: move to webidl

* fix: move it under webidl

* fixup: rename it to markAsUncloneable

* fix: mark more web instances uncloneable

* fixup

---------

Co-authored-by: Khafra <[email protected]>

Author: jazelly

lib/web/cache/cache.js

@@ -36,6 +36,7 @@ class Cache {
       webidl.illegalConstructor()
     }
 
+    webidl.util.markAsUncloneable(this)
     this.#relevantRequestResponseList = arguments[1]
   }
 

lib/web/cache/cachestorage.js

@@ -16,6 +16,8 @@ class CacheStorage {
     if (arguments[0] !== kConstruct) {
       webidl.illegalConstructor()
     }
+
+    webidl.util.markAsUncloneable(this)
   }
 
   async match (request, options = {}) {

lib/web/eventsource/eventsource.js

@@ -109,6 +109,8 @@ class EventSource extends EventTarget {
     // 1. Let ev be a new EventSource object.
     super()
 
+    webidl.util.markAsUncloneable(this)
+
     const prefix = 'EventSource constructor'
     webidl.argumentLengthCheck(arguments, 1, prefix)
 

lib/web/fetch/formdata.js

@@ -14,6 +14,8 @@ class FormData {
   #state = []
 
   constructor (form) {
+    webidl.util.markAsUncloneable(this)
+
     if (form !== undefined) {
       throw webidl.errors.conversionFailed({
         prefix: 'FormData constructor',

lib/web/fetch/headers.js

@@ -436,6 +436,8 @@ class Headers {
    * @returns
    */
   constructor (init = undefined) {
+    webidl.util.markAsUncloneable(this)
+
     if (init === kConstruct) {
       return
     }

lib/web/fetch/request.js

@@ -92,6 +92,8 @@ class Request {
 
   // https://fetch.spec.whatwg.org/#dom-request
   constructor (input, init = undefined) {
+    webidl.util.markAsUncloneable(this)
+
     if (input === kConstruct) {
       return
     }

lib/web/fetch/response.js

@@ -112,6 +112,8 @@ class Response {
 
   // https://fetch.spec.whatwg.org/#dom-response
   constructor (body = null, init = undefined) {
+    webidl.util.markAsUncloneable(this)
+
     if (body === kConstruct) {
       return
     }

lib/web/fetch/webidl.js

@@ -1,6 +1,7 @@
 'use strict'
 
 const { types, inspect } = require('node:util')
+const { markAsUncloneable } = require('node:worker_threads')
 const { toUSVString } = require('../../core/util')
 
 const UNDEFINED = 1
@@ -131,6 +132,8 @@ webidl.util.TypeValueToString = function (o) {
   }
 }
 
+webidl.util.markAsUncloneable = markAsUncloneable || (() => {})
+
 // https://webidl.spec.whatwg.org/#abstract-opdef-converttoint
 webidl.util.ConvertToInt = function (V, bitLength, signedness, opts) {
   let upperBound

lib/web/websocket/events.js

@@ -13,6 +13,7 @@ class MessageEvent extends Event {
   constructor (type, eventInitDict = {}) {
     if (type === kConstruct) {
       super(arguments[1], arguments[2])
+      webidl.util.markAsUncloneable(this)
       return
     }
 
@@ -25,6 +26,7 @@ class MessageEvent extends Event {
     super(type, eventInitDict)
 
     this.#eventInit = eventInitDict
+    webidl.util.markAsUncloneable(this)
   }
 
   get data () {
@@ -111,6 +113,7 @@ class CloseEvent extends Event {
     super(type, eventInitDict)
 
     this.#eventInit = eventInitDict
+    webidl.util.markAsUncloneable(this)
   }
 
   get wasClean () {
@@ -141,6 +144,7 @@ class ErrorEvent extends Event {
     webidl.argumentLengthCheck(arguments, 1, prefix)
 
     super(type, eventInitDict)
+    webidl.util.markAsUncloneable(this)
 
     type = webidl.converters.DOMString(type, prefix, 'type')
     eventInitDict = webidl.converters.ErrorEventInit(eventInitDict ?? {})

lib/web/websocket/websocket.js

@@ -100,6 +100,8 @@ class WebSocket extends EventTarget {
   constructor (url, protocols = []) {
     super()
 
+    webidl.util.markAsUncloneable(this)
+
     const prefix = 'WebSocket constructor'
     webidl.argumentLengthCheck(arguments, 1, prefix)