Skip to content

test: add missing r.close() calls in REPL multiline tests #60226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2025
Merged

test: add missing r.close() calls in REPL multiline tests #60226

merged 1 commit into from
Nov 17, 2025

Conversation

@Han5991
Copy link
Contributor

@Han5991 Han5991 commented Oct 12, 2025 •
edited
Loading

Summary

  • Adds missing r.close() calls to 4 test cases in test/parallel/test-repl-multiline-navigation.js
  • Prevents resource leaks by properly cleaning up REPL instances after each test
  • Ensures test isolation and improves reliability in CI environments
image image

Test plan

  • Run the modified test file: ./node test/parallel/test-repl-multiline-navigation.js
  • Verify all tests pass without resource warnings
  • Run full REPL test suite: tools/test.py repl
  • Check for any memory leak indicators in test output

@Han5991
test: add missing r.close() calls in REPL multiline tests
57da92f 
Adds missing REPL instance cleanup calls to prevent resource leaks
in test/parallel/test-repl-multiline-navigation.js. Each test now
properly closes the REPL instance after testing cursor navigation.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 12, 2025
@Han5991 Han5991 marked this pull request as ready for review October 12, 2025 08:07
@codecov
Copy link

codecov bot commented Oct 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (f9fcc74) to head (57da92f).
⚠️ Report is 291 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #60226   +/-   ##
=======================================
  Coverage   88.56%   88.57%           
=======================================
  Files         704      704           
  Lines      208125   208125           
  Branches    40003    40009    +6     
=======================================
+ Hits       184332   184338    +6     
- Misses      15809    15815    +6     
+ Partials     7984     7972   -12

see 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 4, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70036/

@Han5991
Copy link
Contributor Author

Han5991 commented Nov 5, 2025

@BridgeAR

The CI run shows failures on Linux and AIX platforms. Could you please trigger a new CI run to check if these are flaky test failures?

The changes in this PR only add missing r.close() calls in REPL multiline tests, which shouldn't affect platform-specific behavior.

Thank you!

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70063/

@Renegade334 Renegade334 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2025
@nodejs-github-bot nodejs-github-bot merged commit 8131d38 into nodejs:main Nov 17, 2025
91 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 17, 2025

Landed in 8131d38

targos pushed a commit that referenced this pull request Nov 27, 2025
@Han5991 @targos
test: add missing r.close() calls in REPL multiline tests
e093c6e 
Adds missing REPL instance cleanup calls to prevent resource leaks
in test/parallel/test-repl-multiline-navigation.js. Each test now
properly closes the REPL instance after testing cursor navigation.

PR-URL: #60226
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Han5991 @nodejs-github-bot @BridgeAR @Renegade334