diff --git a/doc/api/http.md b/doc/api/http.md index 71a7bb1db942cc..bb6a3afaf9fdf7 100644 --- a/doc/api/http.md +++ b/doc/api/http.md @@ -745,7 +745,7 @@ added: v0.1.94 --> * `response` {http.IncomingMessage} -* `socket` {stream.Duplex} +* `stream` {stream.Duplex} * `head` {Buffer} Emitted each time a server responds to a request with an upgrade. If this @@ -768,13 +768,13 @@ const server = http.createServer((req, res) => { res.writeHead(200, { 'Content-Type': 'text/plain' }); res.end('okay'); }); -server.on('upgrade', (req, socket, head) => { - socket.write('HTTP/1.1 101 Web Socket Protocol Handshake\r\n' + +server.on('upgrade', (req, stream, head) => { + stream.write('HTTP/1.1 101 Web Socket Protocol Handshake\r\n' + 'Upgrade: WebSocket\r\n' + 'Connection: Upgrade\r\n' + '\r\n'); - socket.pipe(socket); // echo back + stream.pipe(stream); // echo back }); // Now that server is running @@ -793,9 +793,9 @@ server.listen(1337, '127.0.0.1', () => { const req = http.request(options); req.end(); - req.on('upgrade', (res, socket, upgradeHead) => { + req.on('upgrade', (res, stream, upgradeHead) => { console.log('got upgraded!'); - socket.end(); + stream.end(); process.exit(0); }); }); @@ -809,13 +809,13 @@ const server = http.createServer((req, res) => { res.writeHead(200, { 'Content-Type': 'text/plain' }); res.end('okay'); }); -server.on('upgrade', (req, socket, head) => { - socket.write('HTTP/1.1 101 Web Socket Protocol Handshake\r\n' + +server.on('upgrade', (req, stream, head) => { + stream.write('HTTP/1.1 101 Web Socket Protocol Handshake\r\n' + 'Upgrade: WebSocket\r\n' + 'Connection: Upgrade\r\n' + '\r\n'); - socket.pipe(socket); // echo back + stream.pipe(stream); // echo back }); // Now that server is running @@ -834,9 +834,9 @@ server.listen(1337, '127.0.0.1', () => { const req = http.request(options); req.end(); - req.on('upgrade', (res, socket, upgradeHead) => { + req.on('upgrade', (res, stream, upgradeHead) => { console.log('got upgraded!'); - socket.end(); + stream.end(); process.exit(0); }); }); @@ -1674,6 +1674,14 @@ per connection (in the case of HTTP Keep-Alive connections).