Skip to content

Conversation

@panva
Copy link
Member

@panva panva commented Feb 21, 2023

  1. Updates the test/wpt/test-{wptmodule}.js setup files, common setups are pushed to the WPT Runner, lint rule is updated to not need to require('../common')
  2. Removes various prototype changes just to satisfy idlharness tests, it's ok for them to fail!
  3. Automatically skips running .tentative fixtures
  4. Automatically skips running fixtures using WorkerGlobalScope.importScripts().
  5. Updates all WPT fixtures

There is one new acknowledged failure that I think might be a bug (Reading Blob.stream() with BYOB reader in test/wpt/test-blob.js cc @nodejs/streams if you want to follow up on that failing test.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 21, 2023
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2023
@nodejs-github-bot

This comment was marked as outdated.

Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not easy to review it right now. I recommend splitting it into multiple commits.

@panva panva added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Feb 21, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

Copy link

@emarhin emarhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not bad

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@panva
Copy link
Member Author

panva commented Feb 23, 2023

I'm going to pass on this change, it's a big one and i'll rather do them in smaller steps that are backportable at least to v18.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants