Skip to content

src: lib/internal/timers.js var -> let/const #30314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: lib/internal/timers.js var -> let/const #30314

wants to merge 1 commit into from

Conversation

@nikolaykrashnikov
Copy link
Contributor

@nikolaykrashnikov nikolaykrashnikov commented Nov 6, 2019 •
edited
Loading

src: lib/internal/timers.js change var to let/const

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Nov 6, 2019
@ChALkeR ChALkeR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2019
trivikr
trivikr reviewed Nov 6, 2019
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 7, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26433/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 12, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26511/

gireeshpunathil pushed a commit that referenced this pull request Nov 17, 2019
@nikolaykrashnikov @gireeshpunathil
src: lib/internal/timers.js var -> let/const
9bda2bb 
PR-URL: #30314
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 17, 2019

landed in 9bda2bb, thanks for the contribution!

BridgeAR pushed a commit that referenced this pull request Nov 19, 2019
@nikolaykrashnikov @BridgeAR
src: lib/internal/timers.js var -> let/const
d648c93 
PR-URL: #30314
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@nikolaykrashnikov @targos
src: lib/internal/timers.js var -> let/const
56b3205 
PR-URL: #30314
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@nikolaykrashnikov @MylesBorins
src: lib/internal/timers.js var -> let/const
3d7882e 
PR-URL: #30314
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

+2 more reviewers

@ChALkeR ChALkeR ChALkeR approved these changes

@devnexen devnexen devnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@nikolaykrashnikov @nodejs-github-bot @gireeshpunathil @ChALkeR @jasnell @gengjiawen @devnexen @BridgeAR @trivikr