build: re-enable custom V8 snapshot by default #28181

joyeecheung · 2019-06-11T19:46:43Z

tools: assert that the snapshot can be rehashed in node_mksnapshot

build: turn on custom V8 snapshot by default

This patch re-enables custom V8 snapshot integration. Also renames
the experimental configure switch from --with-node-snapshot
to --without-node-snapshot to be consistent with--without-snapshot
which is used for the default V8 snapshot.

Refs: #27365
Refs: #17058

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

This patch re-enables custom V8 snapshot integration. Also renames the experimental configure switch from `--with-node-snapshot` to `--without-node-snapshot` to be consistent with`--without-snapshot` which is used for the default V8 snapshot.

nodejs-github-bot · 2019-06-11T19:46:46Z

Sadly, an error occurred when I tried to trigger a build. :(
CI: https://ci.nodejs.org/job/node-test-pull-request/23800/
CI: https://ci.nodejs.org/job/node-test-pull-request/23815/

joyeecheung · 2019-06-11T19:54:18Z

pummel/test-hash-seed CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/7398/

bnoordhuis

Refs: #27365
Refs: #28181

That second Refs: is rather self-referential. ^^

joyeecheung · 2019-06-12T08:17:48Z

@bnoordhuis Oops, it's supposed to be #17058 thanks for catching that.

joyeecheung · 2019-06-17T02:16:43Z

Landed in 28d3f19

PR-URL: #28181 Refs: #27365 Refs: #17058 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>

This patch re-enables custom V8 snapshot integration. Also renames the experimental configure switch from `--with-node-snapshot` to `--without-node-snapshot` to be consistent with`--without-snapshot` which is used for the default V8 snapshot. PR-URL: #28181 Refs: #27365 Refs: #17058 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: #28181 Refs: #27365 Refs: #17058 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>

This patch re-enables custom V8 snapshot integration. Also renames the experimental configure switch from `--with-node-snapshot` to `--without-node-snapshot` to be consistent with`--without-snapshot` which is used for the default V8 snapshot. PR-URL: #28181 Refs: #27365 Refs: #17058 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: #28181 Refs: #27365 Refs: #17058 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>

This patch re-enables custom V8 snapshot integration. Also renames the experimental configure switch from `--with-node-snapshot` to `--without-node-snapshot` to be consistent with`--without-snapshot` which is used for the default V8 snapshot. PR-URL: #28181 Refs: #27365 Refs: #17058 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Notable changes: This release contains `semver-major` commits. These are in fact not `semver-major` due to follow-up commits that remove all breaking changes. * build: * The startup time is reduced by enabling V8 snapshots by default #28181 * deps: * Updated `V8` to 7.5.288.22 #27375 * The numeric separator (v8.dev/features/numeric-separators) feature is now enabled by default * Updated `OpenSSL` to 1.1.1c #28211 * inspector: * The `--inspect-publish-uid` flag was added to specify ways of the inspector web socket url exposure #27741 * n-api: * Accessors on napi_define_* are now ECMAScript-compliant #27851 * report: * The cpu info got added to the report output #28188 * src: * Restore the original state of the stdio file descriptors on exit to prevent leaving stdio in raw or non-blocking mode #24260 * tools,gyp: * Introduce MSVS 2019 #27375 * util: * inspect: * Array grouping became more compact and uses more columns than before #28059 #28070 * Long strings will not be split at 80 characters anymore. Instead they will be split on new lines #28055 * worker: * `worker.terminate()` now returns a promise and using the callback is deprecated #28021 PR-URL: #28268

Notable changes: * build: * The startup time is reduced by enabling V8 snapshots by default #28181 * deps: * Updated `V8` to 7.5.288.22 #27375 * The numeric separator (v8.dev/features/numeric-separators) feature is now enabled by default * Updated `OpenSSL` to 1.1.1c #28211 * inspector: * The `--inspect-publish-uid` flag was added to specify ways of the inspector web socket url exposure #27741 * n-api: * Accessors on napi_define_* are now ECMAScript-compliant #27851 * report: * The cpu info got added to the report output #28188 * src: * Restore the original state of the stdio file descriptors on exit to prevent leaving stdio in raw or non-blocking mode #24260 * tools,gyp: * Introduce MSVS 2019 #27375 * util: * inspect: * Array grouping became more compact and uses more columns than before #28059 #28070 * Long strings will not be split at 80 characters anymore. Instead they will be split on new lines #28055 * worker: * `worker.terminate()` now returns a promise and using the callback is deprecated #28021 PR-URL: #28268

Notable changes: * build: * The startup time is reduced by enabling V8 snapshots by default nodejs#28181 * deps: * Updated `V8` to 7.5.288.22 nodejs#27375 * The numeric separator (v8.dev/features/numeric-separators) feature is now enabled by default * Updated `OpenSSL` to 1.1.1c nodejs#28211 * inspector: * The `--inspect-publish-uid` flag was added to specify ways of the inspector web socket url exposure nodejs#27741 * n-api: * Accessors on napi_define_* are now ECMAScript-compliant nodejs#27851 * report: * The cpu info got added to the report output nodejs#28188 * src: * Restore the original state of the stdio file descriptors on exit to prevent leaving stdio in raw or non-blocking mode nodejs#24260 * tools,gyp: * Introduce MSVS 2019 nodejs#27375 * util: * inspect: * Array grouping became more compact and uses more columns than before nodejs#28059 nodejs#28070 * Long strings will not be split at 80 characters anymore. Instead they will be split on new lines nodejs#28055 * worker: * `worker.terminate()` now returns a promise and using the callback is deprecated nodejs#28021 PR-URL: nodejs#28268

joyeecheung added 2 commits June 12, 2019 03:16

tools: assert that the snapshot can be rehashed in node_mksnapshot

7d917d3

nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Jun 11, 2019

targos approved these changes Jun 11, 2019

View reviewed changes

devsnek approved these changes Jun 11, 2019

View reviewed changes

addaleax approved these changes Jun 11, 2019

View reviewed changes

joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 11, 2019

refack approved these changes Jun 11, 2019

View reviewed changes

bnoordhuis approved these changes Jun 12, 2019

View reviewed changes

joyeecheung mentioned this pull request Jun 12, 2019

git-node: check if there are duplicates in Refs and PR-URL nodejs/node-core-utils#350

Closed

BridgeAR mentioned this pull request Jun 12, 2019

Automatic CI does not always work nodejs/build#1833

Closed

BridgeAR approved these changes Jun 12, 2019

View reviewed changes

jasnell approved these changes Jun 14, 2019

View reviewed changes

Trott approved these changes Jun 17, 2019

View reviewed changes

joyeecheung closed this Jun 17, 2019

BridgeAR mentioned this pull request Jun 17, 2019

v12.5.0 proposal #28268

Merged

BridgeAR added the notable-change PRs with changes that should be highlighted in changelogs. label Jun 20, 2019

styfle mentioned this pull request Jun 27, 2019

RFC: speeding up Node.js startup using V8 snapshot #17058

Closed

jasonkuhrt mentioned this pull request Mar 20, 2020

Server System prisma-labs/graphql-framework-experiment#295

Open

kissofire mentioned this pull request Jul 22, 2022

[Snyk] Fix for 1 vulnerabilities kissofire/node#73

Open

wedataintelligence mentioned this pull request Jul 22, 2022

[Snyk] Fix for 1 vulnerabilities wedataintelligence/node#38

Open

ron-a20 mentioned this pull request Jul 22, 2022

[Snyk] Fix for 1 vulnerabilities ron-a20/node#71

Open

Dmarch28 mentioned this pull request Jul 22, 2022

[Snyk] Fix for 1 vulnerabilities Dmarch28/node#62

Open

aliceUnhinged613 mentioned this pull request Jul 22, 2022

[Snyk] Fix for 1 vulnerabilities aliceUnhinged613/node#64

Open

137717unity mentioned this pull request Jul 22, 2022

[Snyk] Fix for 1 vulnerabilities 137717unity/node#62

Open

baby636 mentioned this pull request Jul 22, 2022

[Snyk] Fix for 1 vulnerabilities baby636/node#61

Open

molllyn1 mentioned this pull request Jul 23, 2022

[Snyk] Fix for 1 vulnerabilities molllyn1/node#53

Open

joyeecheung mentioned this pull request Apr 20, 2023

Tracking issue: snapshot integration in Node.js core #35711

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

build: re-enable custom V8 snapshot by default #28181

build: re-enable custom V8 snapshot by default #28181

Uh oh!

joyeecheung commented Jun 11, 2019 •

edited

Loading

Uh oh!

nodejs-github-bot commented Jun 11, 2019 •

edited

Loading

Uh oh!

joyeecheung commented Jun 11, 2019

Uh oh!

bnoordhuis left a comment

Uh oh!

joyeecheung commented Jun 12, 2019

Uh oh!

joyeecheung commented Jun 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

build: re-enable custom V8 snapshot by default #28181

build: re-enable custom V8 snapshot by default #28181

Uh oh!

Conversation

joyeecheung commented Jun 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

tools: assert that the snapshot can be rehashed in node_mksnapshot

build: turn on custom V8 snapshot by default

Checklist

Uh oh!

nodejs-github-bot commented Jun 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joyeecheung commented Jun 11, 2019

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

joyeecheung commented Jun 12, 2019

Uh oh!

joyeecheung commented Jun 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

joyeecheung commented Jun 11, 2019 •

edited

Loading

nodejs-github-bot commented Jun 11, 2019 •

edited

Loading