Skip to content

doc: fix code lang in repl.md #26075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: fix code lang in repl.md #26075

wants to merge 1 commit into from

Conversation

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Feb 13, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem. labels Feb 13, 2019
vsemozhetbyt
vsemozhetbyt reviewed Feb 13, 2019
View reviewed changes
@richardlau
Copy link
Member

richardlau commented Feb 13, 2019

There are other instances in this file of the repl being started from the command line (node ...) and they're currently using js. Either all of them should be changed for consistency or the instance being changed here left alone.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Feb 13, 2019

It seems they were marked as js so that code and outputted literals are js-highlighted.

@gengjiawen
Copy link
Member Author

gengjiawen commented Feb 14, 2019

It's not js actually. So better to change it.

lance
lance reviewed Feb 14, 2019
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how changing the code sections to bash is an improvement. It's not pure JavaScript since it's in the REPL, but it seems closer to JS than to bash, in my opinion. If we're going to be strict about it, I would say that in most code examples on this file, there should be no language specified.

@gengjiawen
Copy link
Member Author

gengjiawen commented Feb 14, 2019

Refactor it to console, inspired by https://stackoverflow.com/a/49004070/1713757.

@danbev
Copy link
Contributor

danbev commented Feb 19, 2019

CI lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2664/

@danbev
Copy link
Contributor

danbev commented Feb 19, 2019

Landed in a993160.

@danbev danbev closed this Feb 19, 2019
danbev pushed a commit that referenced this pull request Feb 19, 2019
@gengjiawen @danbev
doc: fix code lang in repl.md
a993160 
PR-URL: #26075
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 19, 2019
@gengjiawen @addaleax
doc: fix code lang in repl.md
db9ec5a 
PR-URL: #26075
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@gengjiawen @rvagg
doc: fix code lang in repl.md
8fac54a 
PR-URL: #26075
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@lance lance lance approved these changes

@danbev danbev danbev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gengjiawen @richardlau @vsemozhetbyt @danbev @lance @nodejs-github-bot