From 0e17f4e5f26a54e16489669850bdace54de80780 Mon Sep 17 00:00:00 2001 From: Vse Mozhet Byt Date: Tue, 25 Apr 2017 02:38:52 +0300 Subject: [PATCH 1/2] doc: improve UX in readline.md code examples Add spaces between output and input for better readability. --- doc/api/readline.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/readline.md b/doc/api/readline.md index fae993a37e520b..0c1721f4a8bf5a 100644 --- a/doc/api/readline.md +++ b/doc/api/readline.md @@ -158,7 +158,7 @@ For example: ```js rl.on('SIGINT', () => { - rl.question('Are you sure you want to exit?', (answer) => { + rl.question('Are you sure you want to exit? ', (answer) => { if (answer.match(/^y(es)?$/i)) rl.pause(); }); }); @@ -255,7 +255,7 @@ If the `readline.Interface` was created with `output` set to `null` or Example usage: ```js -rl.question('What is your favorite food?', (answer) => { +rl.question('What is your favorite food? ', (answer) => { console.log(`Oh, so your favorite food is ${answer}`); }); ``` From 2a6b727756c24cdb000b326c5bb8d8431923c002 Mon Sep 17 00:00:00 2001 From: Vse Mozhet Byt Date: Tue, 25 Apr 2017 02:42:58 +0300 Subject: [PATCH 2/2] doc: replace indexOf by startsWith in readline.md --- doc/api/readline.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/readline.md b/doc/api/readline.md index 0c1721f4a8bf5a..93e3bcbf41eb72 100644 --- a/doc/api/readline.md +++ b/doc/api/readline.md @@ -414,7 +414,7 @@ For instance: `[[substr1, substr2, ...], originalsubstring]`. ```js function completer(line) { const completions = '.help .error .exit .quit .q'.split(' '); - const hits = completions.filter((c) => c.indexOf(line) === 0); + const hits = completions.filter((c) => c.startsWith(line)); // show all completions if none found return [hits.length ? hits : completions, line]; }