From 3cf43994dd2c1f456df3ff0905b7b6c60588ac7d Mon Sep 17 00:00:00 2001
From: Jonathan Boarman <jb@jonathan.net>
Date: Sun, 4 Dec 2016 06:43:43 -0600
Subject: [PATCH] doc: correct vcbuild options for windows testing

Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.
---
 BUILDING.md     | 8 ++++----
 CONTRIBUTING.md | 6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/BUILDING.md b/BUILDING.md
index b98bb75d79b656..b5e9293d19c1fd 100644
--- a/BUILDING.md
+++ b/BUILDING.md
@@ -121,7 +121,7 @@ Prerequisites:
 To run the tests:
 
 ```console
-> .\vcbuild test
+> .\vcbuild nosign test
 ```
 
 To test if Node.js was built correctly:
@@ -179,7 +179,7 @@ $ ./configure --with-intl=full-icu --download=all
 ##### Windows:
 
 ```console
-> .\vcbuild full-icu download-all
+> .\vcbuild nosign full-icu download-all
 ```
 
 #### Building without Intl support
@@ -196,7 +196,7 @@ $ ./configure --without-intl
 ##### Windows:
 
 ```console
-> .\vcbuild without-intl
+> .\vcbuild nosign without-intl
 ```
 
 #### Use existing installed ICU (Unix / OS X only):
@@ -239,7 +239,7 @@ First unpack latest ICU to `deps/icu`
 as `deps/icu` (You'll have: `deps/icu/source/...`)
 
 ```console
-> .\vcbuild full-icu
+> .\vcbuild nosign full-icu
 ```
 
 ## Building Node.js with FIPS-compliant OpenSSL
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 6d419aa4954fde..f198c82ee2f2f1 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -167,7 +167,7 @@ $ ./configure && make -j4 test
 Windows:
 
 ```text
-> vcbuild test
+ .\vcbuild nosign test
 ```
 
 (See the [BUILDING.md](./BUILDING.md) for more details.)
@@ -175,11 +175,11 @@ Windows:
 Make sure the linter is happy and that all tests pass. Please, do not submit
 patches that fail either check.
 
-Running `make test`/`vcbuild test` will run the linter as well unless one or
+Running `make test`/`.\vcbuild nosign test` will run the linter as well unless one or
 more tests fail.
 
 If you want to run the linter without running tests, use
-`make lint`/`vcbuild jslint`.
+`make lint`/`.\vcbuild nosign jslint`.
 
 If you are updating tests and just want to run a single test to check it, you
 can use this syntax to run it exactly as the test harness would: