Skip to content

Commit e9959ab

Browse files
Trottjasnell
authored andcommitted
test: remove unnecessary assignments
common.js needs to be loaded in all tests so that there is checking for variable leaks and possibly other things. However, it does not need to be assigned to a variable if nothing in common.js is referred to elsewhere in the test. The main tradeoff for this bit of code churn is that it gets the code base most of the way to being able to enable the no-unused-vars rule in eslint. (The non-tooling benefit is that it lessens cognitive load when reading tests as it is an immediate indication that none of the functions or properties in common.js will be used by the test.) PR-URL: #4563 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
1 parent 82c9778 commit e9959ab

File tree

307 files changed

+316
-317
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

307 files changed

+316
-317
lines changed

β€Žtest/internet/test-dns-txt-sigsegv.jsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var common = require('../common');
2+
require('../common');
33
var assert = require('assert');
44
var dns = require('dns');
55

β€Žtest/internet/test-dns.jsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var common = require('../common');
2+
require('../common');
33
var assert = require('assert'),
44
dns = require('dns'),
55
net = require('net'),

β€Žtest/internet/test-http-dns-fail.jsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* should trigger the error event after each attempt.
55
*/
66

7-
var common = require('../common');
7+
require('../common');
88
var assert = require('assert');
99
var http = require('http');
1010

β€Žtest/internet/test-net-connect-timeout.jsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// https://groups.google.com/forum/#!topic/nodejs/UE0ZbfLt6t8
44
// https://groups.google.com/forum/#!topic/nodejs-dev/jR7-5UDqXkw
55

6-
var common = require('../common');
6+
require('../common');
77
var net = require('net');
88
var assert = require('assert');
99

β€Žtest/internet/test-net-connect-unref.jsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var common = require('../common');
2+
require('../common');
33
var assert = require('assert');
44
var net = require('net');
55

β€Žtest/message/2100bytes.jsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var common = require('../common');
2+
require('../common');
33
var assert = require('assert');
44
var util = require('util');
55

β€Žtest/message/core_line_numbers.jsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
const common = require('../common');
2+
require('../common');
33
const punycode = require('punycode');
44

55
// This test verifies that line numbers in core modules are reported correctly.

β€Žtest/message/error_exit.jsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var common = require('../common');
2+
require('../common');
33
var assert = require('assert');
44

55
process.on('exit', function(code) {

β€Žtest/message/eval_messages.jsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
var common = require('../common');
3+
require('../common');
44
var assert = require('assert');
55

66
var spawn = require('child_process').spawn;

β€Žtest/message/hello_world.jsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var common = require('../common');
2+
require('../common');
33
var assert = require('assert');
44

55
console.log('hello world');

0 commit comments

Comments
Β (0)