Skip to content

Commit 07d4183

Browse files
committed
console: Add noop impls of methods required in spec
- this conforms to the following spec - https://github.com/DeveloperToolsWG/console-object/blob/master/api.md
1 parent a3b238a commit 07d4183

3 files changed

Lines changed: 90 additions & 0 deletions

File tree

doc/api/console.markdown

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,24 @@ to the current position.
105105
Similar to [assert.ok()][], but the error message is formatted as
106106
`util.format(message...)`.
107107

108+
### Compatibility functions
109+
110+
NOTE: The following functions are defined for compatibility purpose, and are not expected to do anything
111+
112+
* `console.group`
113+
* `console.groupCollapsed`
114+
* `console.groupEnd`
115+
* `console.clear`
116+
* `console.count`
117+
* `console.dirxml`
118+
* `console.isIndependentlyComposed`
119+
* `console.table`
120+
* `console.profile`
121+
* `console.profileEnd`
122+
* `console.timeline`
123+
* `console.timelineEnd`
124+
* `console.timeStamp`
125+
108126
## Class: Console
109127

110128
<!--type=class-->

lib/console.js

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,5 +90,47 @@ Console.prototype.assert = function(expression) {
9090
};
9191

9292

93+
Console.prototype.group = noop;
94+
95+
96+
Console.prototype.groupCollapsed = noop;
97+
98+
99+
Console.prototype.groupEnd = noop;
100+
101+
102+
Console.prototype.clear = noop;
103+
104+
105+
Console.prototype.count = noop;
106+
107+
108+
Console.prototype.dirxml = noop;
109+
110+
111+
Console.prototype.isIndependentlyComposed = noop;
112+
113+
114+
Console.prototype.table = noop;
115+
116+
117+
Console.prototype.profile = noop;
118+
119+
120+
Console.prototype.profileEnd = noop;
121+
122+
123+
Console.prototype.timeline = noop;
124+
125+
126+
Console.prototype.timelineEnd = noop;
127+
128+
129+
Console.prototype.timeStamp = noop;
130+
131+
132+
function noop() {}
133+
134+
93135
module.exports = new Console(process.stdout, process.stderr);
94136
module.exports.Console = Console;

test/parallel/test-console.js

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,36 @@ assert.doesNotThrow(function() {
1717
console.timeEnd('label');
1818
});
1919

20+
assert.doesNotThrow(function() {
21+
console.group('test');
22+
console.groupEnd();
23+
});
24+
25+
assert.doesNotThrow(function() {
26+
console.groupCollapsed('test');
27+
console.groupEnd();
28+
});
29+
30+
assert.doesNotThrow(console.clear);
31+
32+
assert.doesNotThrow(console.count);
33+
34+
assert.doesNotThrow(console.dirxml);
35+
36+
assert.doesNotThrow(console.exception);
37+
38+
assert.doesNotThrow(console.isIndependentlyComposed);
39+
40+
assert.doesNotThrow(console.profile);
41+
42+
assert.doesNotThrow(console.profileEnd);
43+
44+
assert.doesNotThrow(console.timeline);
45+
46+
assert.doesNotThrow(console.timelineEnd);
47+
48+
assert.doesNotThrow(console.timeStamp);
49+
2050
// an Object with a custom .inspect() function
2151
var custom_inspect = { foo: 'bar', inspect: function() { return 'inspect'; } };
2252

0 commit comments

Comments
 (0)