Add missing options argument to createSecurePair.

[socketpair]

Also helps in implementation of #6204, where some ptions passed to
createSecurePair and ignored before this patch.

These options are very helpful if someone wants to pass
options.servername or options.SNICallback to securepair.

[indutny]

Great! May I ask you to add a test to not let this slip away again?

[socketpair]

Tests sems valid, but does not work...another bug is blocking my test...:

@indutny need your help. Да, удобнее по-русски, кстати.

=== release test-tls-securepair-fiftharg ===                    
Path: pummel/test-tls-securepair-fiftharg
node: ../src/async-wrap-inl.h:98: v8::Handle<v8::Value> node::AsyncWrap::MakeCallback(v8::Handle<v8::String>, int, v8::Handle<v8::Value>*): Assertion `cb_v->IsFunction()' failed.
Command: out/Release/node ********/node/test/pummel/test-tls-securepair-fiftharg.js

Exactly the same is reproduced with code

pair = tls.createSecurePair(...);
pair.ssl.setSNICallback(function() {});

but pair.ssl is undocumented (and should not be documented, as I think).

Also, seems not reproducible in nodejs 0.10. Also maybe that: #7691 ?

[indutny]

@socketpair there is a bug that should be fixed by nodejs/node#1720

[indutny]

cc @misterdjules please backport this if it sounds good to you! ;)

[indutny]

Btw, why put this test into pummel folder?

[socketpair]

I don't know. I just see some tests about tls in that folder, and put my test in same folder. I can change PR if you say what to fix.

[indutny]

I'd go with test/simple ;) Btw, you could probably try to rebase your branch on top of nodejs/node#1720 to include the fix commit in this PR, and to make sure that it builds correctly.

[socketpair]

I have cherry-picked commit from IOjs that fixed bug in C++

[socketpair]

I have moved test from pummel to simple dir

[socketpair]

Now all tests passed! yay! Please merge!

[socketpair]

not sure if markdown syntax (link) is correct here

[socketpair]

How to speedup merging? who is responsible?

[indutny]

Sorry, but we use 80 column limit everywhere. I may only suggest to convert this to hex and split it before it gets to 80 column. It will be much more compact this way.

[socketpair]

fixed

[indutny]

Sorry for delay! Just one minor nit, otherwise LGTM!

[socketpair]

Hex encoding takess too much space. Just reformat decimal representation.

[indutny]

@socketpair what do you think about reopening this PR for io.js master branch? I have just landed that fix commit that your PR depended upon. ;)

[socketpair]

I'm confused about everything, and forgot what is happening... :( There are nodejs, iojs and two patches in both projects.

I want all fixes to be in both projects. What I should do so?

[indutny]

@socketpair it can't go into v0.12, and so the next release of node is io.js :) I would suggest to open PR for io.js master ;)

[indutny]

Don't forget to cc me there ;)

[jasnell]

@socketpair .. just to reiterate what @indutny said. This is not going to be able to land here. The right thing to do here would be to open a new PR against master on http://github.com/nodejs/node in order to get this landed.

[socketpair]

@jasnell thanks for detailed explanation what should be done.
@indutny CC to you :)

nodejs/node#2441

Should I close this pull request ?

[jasnell]

@socketpair .. no problem. I'll go ahead and close the PR here. Thanks!