feat: promisify remove

An effort to modernize the code

Author: imatlopez

lib/remove.js

@@ -1,46 +1,49 @@
 'use strict'
 
-const fs = require('fs')
-const rm = require('rimraf')
+const fs = require('graceful-fs')
+const rimraf = require('rimraf')
+const util = require('util')
 const path = require('path')
 const log = require('npmlog')
 const semver = require('semver')
 
-function remove (gyp, argv, callback) {
-  var devDir = gyp.devDir
-  log.verbose('remove', 'using node-gyp dir:', devDir)
+async function remove (gyp, argv) {
+  log.verbose('remove', 'using node-gyp dir:', gyp.devDir)
 
   // get the user-specified version to remove
-  var version = argv[0] || gyp.opts.target
+  let version = argv[0] || gyp.opts.target
   log.verbose('remove', 'removing target version:', version)
 
   if (!version) {
-    return callback(new Error('You must specify a version number to remove. Ex: "' + process.version + '"'))
+    throw new Error(`You must specify a version number to remove. Ex: "${process.version}"`)
   }
 
-  var versionSemver = semver.parse(version)
+  const versionSemver = semver.parse(version)
   if (versionSemver) {
     // flatten the version Array into a String
     version = versionSemver.version
   }
 
-  var versionPath = path.resolve(gyp.devDir, version)
+  const versionPath = path.resolve(gyp.devDir, version)
   log.verbose('remove', 'removing development files for version:', version)
 
   // first check if its even installed
-  fs.stat(versionPath, function (err) {
+  try {
+    await fs.promises.stat(versionPath)
+  } catch (err) {
     if (err) {
       if (err.code === 'ENOENT') {
-        callback(null, 'version was already uninstalled: ' + version)
-      } else {
-        callback(err)
+        return 'version was already uninstalled: ' + version
       }
-      return
+      throw err
     }
-    // Go ahead and delete the dir
-    rm(versionPath, callback)
-  })
+  }
+
+  // Go ahead and delete the dir
+  return util.promisify(rimraf)(versionPath)
 }
 
-module.exports = exports = remove
+module.exports = function (gyp, argv, callback) {
+  return remove(gyp, argv).then(callback.bind(undefined, null), callback)
+}
 module.exports.usage = 'Removes the node development files for the specified version'