diff --git a/.travis.yml b/.travis.yml index 1e2e8e0f..6e8c296e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -26,9 +26,10 @@ env: - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="2.0.18" - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="3.1.13" - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="4.2.12" - - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="5.0.11" - - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="6.1.2" - - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="7.0.0" + - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="5.0.13" + - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="6.1.9" + - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="7.1.14" + - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="8.0.3" matrix: exclude: - os: osx diff --git a/nan_typedarray_contents.h b/nan_typedarray_contents.h index d28ae323..c6ac8a41 100644 --- a/nan_typedarray_contents.h +++ b/nan_typedarray_contents.h @@ -31,7 +31,13 @@ class TypedArrayContents { v8::Local buffer = array->Buffer(); length = byte_length / sizeof(T); - data = static_cast(buffer->GetContents().Data()) + byte_offset; +// Actually it's 7.9 here but this would lead to ABI issues with Node.js 13 +// using 7.8 till 13.2.0. +#if (V8_MAJOR_VERSION >= 8) + data = static_cast(buffer->GetBackingStore()->Data()) + byte_offset; +#else + data = static_cast(buffer->GetContents().Data()) + byte_offset; +#endif } #else