Skip to content

Commit 4df6d12

Browse files
committed
Editorial updates addressing comments.
1 parent f1acd78 commit 4df6d12

4 files changed

Lines changed: 12 additions & 10 deletions

File tree

profiling/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
- Heap Profiling
88
- V8 Heap Profiler: [v8/include/v8-profiler.h](https://github.com/v8/blob/master/include/v8-profiler.h)
9-
- Also accessible through built-in 'v8' module.
9+
- Heap memory usage stats are available through built-in 'v8' module.
1010

1111
Name | Sponsor
1212
-----|--------

tracing/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
## Tracing
22
- [AsyncWrap](./AsyncWrap/README.md) - Most native objects are represented indirectly by the [AsyncWrap class](https://github.com/nodejs/node/blob/master/src/async-wrap.h), so hooks have been added to that class to trace lifecycle (init/destroy) and callback activity (pre/post) related to these objects.
33

4-
- [OS Tracing](./os-tracing/README.md) - LTTng (Linux), DTrace (Linux, OSX), ETW (Windows)
4+
- [OS Tracing](./os-tracing/README.md) - LTTng (Linux), SystemTap (Linux), DTrace (OSX), ETW (Windows)
55

66
- [VM Tracing](./vm-tracing/README.md) - Tracing native to JS VMs, such as V8's TRACE_EVENT.
77

tracing/os-tracing/README.md

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,24 @@
22

33
* [DTrace](http://dtrace.org/)
44
Available on IllumOS, Solaris, Mac
5-
The [DTrace blog](http://dtrace.org/blogs/blog/category/node-js/) has some articles on using DTrace with Node.js
5+
6+
- The [DTrace blog](http://dtrace.org/blogs/blog/category/node-js/) has some articles on using DTrace with Node.js
67

78
* [LTTng](http://lttng.org/)
89
Linux only.
9-
Some info on using LTTng with Node.js are available in the presentations
10-
[Tracing Node on Linux with LTTNG](http://nearform.github.io/tracing-node-lttng-nodejsdublin/)
10+
11+
- [Tracing Node on Linux with LTTNG](http://nearform.github.io/tracing-node-lttng-nodejsdublin/)
12+
- [thekemkid/magic-tracing](https://github.com/thekemkid/magic-tracing) is an example of a Node.js application which implements LTTng tracepoints. A demo is available [here](https://asciicinema.org/a/16785).
1113

1214
* [ETW](https://msdn.microsoft.com/en-us/library/windows/desktop/aa363668.aspx)
1315
Windows only.
14-
Some information was provided by Bill Ticehurst (@billti) in
15-
[issue #10](https://github.com/nodejs/tracing-wg/issues/10#issuecomment-137145822)
16-
about how he integrated ETW into Node.js for Windows
16+
17+
- Some information was provided by Bill Ticehurst (@billti) in [issue #10](https://github.com/nodejs/tracing-wg/issues/10#issuecomment-137145822) about how he integrated ETW into Node.js for Windows
1718

1819
* [Perf](https://perf.wiki.kernel.org/)
1920
Linux only.
20-
Can be enabled with `--perf_basic_prof` v8 run-time flag.
21+
22+
- Can be enabled with `--perf_basic_prof` v8 run-time flag.
2123

2224
* [SystemTap](https://sourceware.org/systemtap/)
2325
Linux only.

tracing/vm-tracing/v8-tracing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ V8: `trace_event.h` macros utilize `v8::Platform::AddTraceEvent` to write traces
99
Node uses `DefaultPlatform` from `v8:src/libplatform/default-platform.h` which currently simply returns 0.
1010
A simplistic implementation which logs all trace events to stdout illustrates the basics:
1111

12-
```cpp
12+
```
1313
// from v8:src/libplatform/default-platform.cc
1414
// add `#include <iostream>` to includes
1515

0 commit comments

Comments
 (0)