Mapping key syntax error parsed as if there is no issue

[shockey]

js-yaml appears to be treating badly-formed mapping keys as if they're well-formed.

This was originally raised as a Swagger-Editor issue (swagger-api/swagger-editor#1740).

Example

var jsYaml = require("js-yaml")

const str = `
myObj:
  a: "something"
  b: "some other thing" c: "third thing"
`

jsYaml.safeLoad(str)

Expected result

An error, maybe something along the lines of bad indentation of a mapping entry at line 4, column 24?

Actual result

{  
  myObj:{  
    a:'something',
    b:'some other thing',
    c:'third thing'
  }
}

[webron]

@puzrin - while this is not a critical issue, it does pose challenges to our users from time to time. Any idea if you'll have to look into it? We'd look into submitting a fix ourselves too, just don't want to duplicate the efforts.

[puzrin]

I'd prefer to wait for PR. But prior to do something, there should be clear understanding what spec says about such thing. Probably, the most easy way is to check libyaml-based parsers.

[ingydotnet]

libyaml reports:

      did not find expected key

  was found at document: 1, line: 3, column: 25
  while parsing a block mapping at line: 2, column: 3

[puzrin]

@ingydotnet thanks!

[ingydotnet]

@perlpunk found this test suite case https://github.com/yaml/yaml-test-suite/blob/master/test/JY7Z.tml

[rlidwka]

Fixed in f0f205b (currently in dev branch).