-
-
Notifications
You must be signed in to change notification settings - Fork 285
vivid: init #1938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
vivid: init #1938
Conversation
trueNAHO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this and the detailed description :)
trueNAHO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The testbed is failing:
$ nix run .#testbed:vivid:dark
error:
[...]
error: A definition for option `virtualisation.vmVariant.home-manager.users.guest.xdg.configFile."vivid/themes/stylix.yml".source' is not of type `absolute path'. Definition values:
- In `/nix/store/4c04v6w92rikfc3dmljdyp0jhgrhfg0s-source/modules/programs/vivid.nix':
[
{
archives = {
font-style = "bold";
foreground = "base05";
...fe0d43f to
4ddc368
Compare
trueNAHO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we resolve #1938 (comment) before merging this PR, or should we defer this to an upstream PR?
I made an issue referencing it. The module maintainer is quite active, so we should get a response pretty fast. I also pushed a new change addressing the problem with the theme. I forced a JSON structure in the file for now, bypassing the number problem. If the response to the issue is positive regarding the 2nd point (either introducing an option or always use JSON), we can remove the "hack": xdg.configFile."vivid/themes/${theme}.yml".source = lib.mkForce (
pkgs.writeText "${theme}.json" (
builtins.toJSON config.programs.vivid.themes.${theme}
)
); |
f22656e to
942535e
Compare
|
Since nix-community/home-manager#7996 got merged, I guess we can now thinker with adding the module finally to stylix. |
7308362 to
c9c6e49
Compare
|
The tests are passing on my machine now, I guess the CI just didn't have resources now to perform it too. |
trueNAHO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after resolving #1938 (comment) by merging #2035 first.
Thanks for your help! |
Initilize the vivid module with stylix. With the PR nix-community home-manager 7979 merged, it is possible to configure the module using base16 theming. Closes 560
Initilize the vivid module with stylix.
With the PR nix-community/home-manager#7979 merged, it is possible to configure the module using base16 theming.
It is mainly inspired by using catppuccin themes and porting the adequate colors over from tinted theming.
Closes #560
I am not sure if the testbed is enough. Some feedback would be welcome!
Example image of the colors on my system:
