-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
aerospace: overhaul settings, add auto-reload and assertions #8166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ommand are used instead of start-at-login and after-login-command
|
Why did you remove |
|
@leon-erd I've fixed it. It's not necessary to use |
|
Yes I have just checked it :) It does work! I'm fine with merging |
Description
This PR introduces a significant refactor of the
aerospaceconfiguration system to make it simpler and more powerful.The most notable change is renaming
userSettingstosettings. This branch also introducesauto-reloadingof the config file and addsassertionsto guide users toward an updated configuration structure.Key Changes:
Rename:
userSettingshas been renamed tosettingsfor simplicity (#6895).Feature: The config file will now
auto-reloadon file changes (#7086).Refactor: Removed
extraConfigand consolidated its use into the newsettingskey (#8010).Defaults: Added
default settingsto streamline new user setup.Validation: Added an assertion to ensure users migrate from deprecated keys (
start-at-login,after-login-command) to the correct modern keys (launchd.enable,after-startup-command).Docs: Added more examples for the new
settings(#8010).Tests: Added more tests and fixed expected values to match the new settings structure.
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.