saml2aws: init module #8134
Open
saml2aws: init module #8134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding module to configure saml2aws utility using home-manager
khaneliman
reviewed
Nov 5, 2025
Comment on lines
+384
to
+395
| mokrinsky = { | ||
| name = "mokrinsky"; | ||
| email = "[email protected]"; | ||
| github = "mokrinsky"; | ||
| githubId = 463907; | ||
| keys = [ | ||
| { | ||
| longkeyid = "rsa4096/0x73CC011921471A15"; | ||
| fingerprint = "EA54 E892 D96C 779E 1FA6 4E0A 73CC 0119 2147 1A15"; | ||
| } | ||
| ]; | ||
| }; |
Collaborator
There was a problem hiding this comment.
Separate commit before module addition, please.
| enable = lib.mkEnableOption "saml2aws CLI tool"; | ||
|
|
||
| package = lib.mkPackageOption pkgs "saml2aws" { | ||
| default = "saml2aws"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| default = "saml2aws"; |
|
|
||
| enableBashIntegration = lib.hm.shell.mkBashIntegrationOption { | ||
| inherit config; | ||
| extraDescription = ''If enabled, this will install autocompletion for bash.''; |
Collaborator
There was a problem hiding this comment.
If the completions are the only benefit of the integration, aren't the shell completions already installed https://github.com/NixOS/nixpkgs/blob/c4e9b72d0bf394509a3b2aff27be35b7e3c99b85/pkgs/by-name/sa/saml2aws/package.nix#L33-L37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding module to configure saml2aws utility.
Description
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.