Skip to content

Conversation

@bmrips
Copy link
Contributor

@bmrips bmrips commented Oct 26, 2025

Description

While working with the code base, I removed some no-ops, especially redundant { ... }: module arguments.

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

  • Code tested through nix run .#tests -- test-all or
    nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

@khaneliman
Copy link
Collaborator

Thanks, thought we setup nixfmt for this... but must have disabled the deadnix linter config for these args because of false positives.

@khaneliman khaneliman merged commit f2f1076 into nix-community:master Oct 26, 2025
7 checks passed
@bmrips bmrips mentioned this pull request Oct 26, 2025
9 tasks
bruceoberg pushed a commit to bruceoberg/home-manager that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants