Skip to content

Conversation

@arunoruto
Copy link
Contributor

@arunoruto arunoruto commented Oct 12, 2025

Description

The current themes option only allows for downloading external YAML themes, and not for generating custom ones with Nix code. This will be useful when styling NixOS and home-manager uniformly with stylix, but nonetheless, it is a helpful option to have, in my opinion.

@aguirre-matteo would be glad to get some feedback on this!

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

  • Code tested through nix run .#tests -- test-all or
    nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

@aguirre-matteo
Copy link
Member

IMO adding another option seems redundant. In any case, we could change the actual themes option to be an attribute set of either a path or yamlFormat.type, and then map cfg.themes to generate the YAML files.

@arunoruto
Copy link
Contributor Author

IMO adding another option seems redundant. In any case, we could change the actual themes option to be an attribute set of either a path or yamlFormat.type, and then map cfg.themes to generate the YAML files.

Fair enough! I guess the current changes make more sense?

@arunoruto arunoruto changed the title vivid: add customThemes option vivid: modify themes option with custom nix entries Oct 12, 2025
@aguirre-matteo aguirre-matteo self-requested a review October 12, 2025 18:57
@khaneliman khaneliman merged commit 904fa32 into nix-community:master Oct 12, 2025
7 checks passed
arunoruto added a commit to arunoruto/stylix that referenced this pull request Oct 12, 2025
Initilize the vivid module with stylix.
With the PR nix-community/home-manager#7979 merged,
it is possible to configure the module using base16 theming.
Closes nix-community#560
arunoruto added a commit to arunoruto/stylix that referenced this pull request Oct 13, 2025
Initilize the vivid module with stylix.
With the PR nix-community/home-manager#7979 merged,
it is possible to configure the module using base16 theming.
Closes nix-community#560
arunoruto added a commit to arunoruto/stylix that referenced this pull request Oct 13, 2025
Initilize the vivid module with stylix.
With the PR nix-community/home-manager#7979 merged,
it is possible to configure the module using base16 theming.
Closes nix-community#560
arunoruto added a commit to arunoruto/stylix that referenced this pull request Oct 13, 2025
Initilize the vivid module with stylix.
With the PR nix-community/home-manager#7979 merged,
it is possible to configure the module using base16 theming.
Closes nix-community#560
arunoruto added a commit to arunoruto/stylix that referenced this pull request Oct 14, 2025
Initilize the vivid module with stylix.
With the PR nix-community/home-manager#7979 merged,
it is possible to configure the module using base16 theming.
Closes nix-community#560
arunoruto added a commit to arunoruto/stylix that referenced this pull request Oct 14, 2025
Initilize the vivid module with stylix.
With the PR nix-community/home-manager#7979 merged,
it is possible to configure the module using base16 theming.
Closes nix-community#560
arunoruto added a commit to arunoruto/stylix that referenced this pull request Oct 14, 2025
Initilize the vivid module with stylix.
With the PR nix-community/home-manager#7979 merged,
it is possible to configure the module using base16 theming.
Closes nix-community#560
@arunoruto arunoruto deleted the vivid/customThemes branch October 14, 2025 16:33
arunoruto added a commit to arunoruto/stylix that referenced this pull request Oct 14, 2025
Initilize the vivid module with stylix.
With the PR nix-community/home-manager#7979 merged,
it is possible to configure the module using base16 theming.
Closes nix-community#560
arunoruto added a commit to arunoruto/stylix that referenced this pull request Oct 14, 2025
Initilize the vivid module with stylix.
With the PR nix-community/home-manager#7979 merged,
it is possible to configure the module using base16 theming.
Closes nix-community#560
arunoruto added a commit to arunoruto/stylix that referenced this pull request Oct 14, 2025
Initilize the vivid module with stylix.
With the PR nix-community/home-manager/pull/7979 merged,
it is possible to configure the module using base16 theming.
Closes 560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants