Skip to content

Conversation

@gth001
Copy link
Contributor

@gth001 gth001 commented Oct 16, 2023

…It displays "Internet offline." until internet is restored.

This fix addresses the issue that with a lost internet connection, clock view continues to display a stale CGM value forever, with no clue that internet connectivity is lost. This fix shows "Internet offline." for the duration that is it lost, then returns to normal when internet is restored.

…It displays "Internet offline." until internet is restored.

This fix addresses the issue that with a lost internet connection, clock view continues to display a stale CGM values forever, with no clue that internet connectivity is lost. This fix shows "Internet offline." for the duration that is it lost, then returns to normal when internet is restored.
@bjornoleh
Copy link
Contributor

bjornoleh commented Oct 16, 2023

Hi @gth001, I saw your message on Discord. You should first change the target branch to dev. Then you should also rebase the PR onto dev, or merge dev into your branch. Or you can start over with dev and apply your changes there and make a new PR.

I hope your fix is a good one that can be merged, I have seen this issue myself.

There are lots of erroneous PRs being made to master when people try to update their forks. If you think your PR is being overlooked, you could try to ping one of the core developers like bewest or sulkaharo. Use @ to tag the usernames I mentioned.

@gth001 gth001 changed the base branch from master to dev October 16, 2023 16:07
@gth001
Copy link
Contributor Author

gth001 commented Oct 16, 2023

You should first change the target branch to dev. Then you should also [...] merge dev into your branch.

Thank you, done.

I have been using this fix for a year or two now, successfully. I have Amazon Fire tablets around my house always showing clock view, and sometimes they lose their wifi connection. Since railway stopped being free, I switched to fly.io but forgot to re-add this fix until I noticed a stale clock at home. So I forked, added the fix again, pointed to my fork, and deployed again to fly.io. Here is the fix in action:

Screen.Recording.2023-10-16.at.10.09.02.AM.1.mp4

(By the way @bewest I am George Francis on facebook, if you remember me, we chatted sometimes.)

@bewest
Copy link
Member

bewest commented Nov 29, 2024

Howdy, this is a great idea, @gth001. Thanks for this. Apologies for the late response as there have been several personal barriers in the last year, although there are 7 maintainers listed besides myself. @bjornoleh, thanks for your encouragement on this, also!

@bewest bewest merged commit 46069a9 into nightscout:dev Nov 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants