Skip to content

Commit 20823d3

Browse files
authored
upgrade minimed-connect-to-nightscout to fix GuardianConnect for US servers (and update npm dependencies) (#4915)
* upgrade minimed-connect-to-nightscout to 1.30to fix GuardianConnect for US servers, see mddub/minimed-connect-to-nightscout#13 * npm update to fix security issue fixes https://nodesecurity.io/advisories/1118 (Arbitrary Code Execution in eslint-utils * update to minimed-connect-to-nightscout 1.3.1 * fix typo and make more clear we don't release with insecure dependencies
1 parent 3b5430d commit 20823d3

File tree

3 files changed

+1435
-3420
lines changed

3 files changed

+1435
-3420
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ Nightscout is a Node.js application. The basic installation of the software for
5757

5858
We develop on the `dev` branch. All new pull requests should be targeted to `dev`. The `master` branch is only used for distributing the latest version of the tested sources.
5959

60-
You can get the dev branch checked out using `git checkout dev`.
60+
You can get the `dev` branch checked out using `git checkout dev`.
6161

6262
Once checked out, install the dependencies using `npm install`, then copy the included `my.env.template`file to `my.env` and edit the file to include your settings (like the Mongo URL). Leave the `NODE_ENV=development` line intact. Once set, run the site using `npm run dev`. This will start Nigthscout in the development mode, with different code packaging rules and automatic restarting of the server using nodemon, when you save changed files on disk. The client also hot-reloads new code in, but it's recommended to reload the the website after changes due to the way the plugin sandbox works.
6363

@@ -119,8 +119,9 @@ We assume all new Pull Requests are at least smoke tested by the author and all
119119
Please include a description of what the features do and rationalize why the changes are needed.
120120

121121
If you add any new NPM module dependencies, you have to rationalize why there are needed - we prefer pull requests that reduce dependencies, not add them.
122+
Before releasing a a new version, we check with `npm audit` if our dependencies don't have known security issues.
122123

123-
When adding new features that add confugration options, please ensure the `README` document is amended with information on the new configuration.
124+
When adding new features that add configuration options, please ensure the `README` document is amended with information on the new configuration.
124125

125126
## Bug fixing
126127

0 commit comments

Comments
 (0)