Skip to content

Crash fix #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2020
Merged

Crash fix #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fe1c22
Fixed Review download crash
ddaddy May 4, 2020
91120db
Updated product identifiers
ddaddy May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Classes/Product.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#define kProductPlatformUniversal @"Universal"
#define kProductPlatformMac @"Mac"
#define kProductPlatformInApp @"In-App"
#define kProductPlatformMacInApp @"Mac In-App"
#define kProductPlatformAppBundle @"App Bundle"
#define kProductPlatformMacAppBundle @"Mac App Bundle"
#define kProductPlatformRenewableSubscription @"Renewable Sub"
Expand Down
14 changes: 14 additions & 0 deletions Classes/Report.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,9 @@ + (Report *)insertNewReportWithCSV:(NSString *)csv inAccount:(ASAccount *)accoun
@"F3": kProductPlatformMac,
@"F7": kProductPlatformMac,
@"IA1": kProductPlatformInApp,
@"IA1-M": kProductPlatformMacInApp,
@"IA9": kProductPlatformInApp,
@"IA9-M": kProductPlatformMacInApp,
@"1-B": kProductPlatformAppBundle,
@"F1-B": kProductPlatformMacAppBundle,
@"IAY": kProductPlatformRenewableSubscription,
Expand Down Expand Up @@ -536,6 +538,12 @@ + (NSSet *)combinedPaidTransactionTypes {
@"1. ", //iPhone App
@"1-B", //App Bundle
@"1-B. ", //App Bundle
@"1E", //Custom iPhone App
@"1E. ", //Custom iPhone App
@"1EP", //Custom iPad App
@"1EP. ", //Custom iPad App
@"1EU", //Custom Universal App
@"1EU. ", //Custom Universal App
@"1F", //Universal App
@"1F. ", //Universal App
@"1T", //iPad App
Expand All @@ -547,13 +555,17 @@ + (NSSet *)combinedPaidTransactionTypes {
@"FI1", //Mac In-App Purchase
@"FI1. ", //Mac In-App Purchase
@"IA1-M", //Mac In-App Purchase
@"IA1-M. ", //Mac In-App Purchase
@"IA1", //In-App Purchase
@"IA1. ", //In-App Purchase
@"IA9", //In-App Subscription
@"IA9. ", //In-App Subscription
@"IA9-M", //In-App Subscription Mac
@"IA9-M. ", //In-App Subscription Mac
@"IAY", //In-App Renewable Subscription
@"IAY. ", //In-App Renewable Subscription
@"IAY-M", //Mac In-App Renewable Subscription
@"IAY-M. ", //Mac In-App Renewable Subscription
@"IAC", //In-App Free Subscription
@"IAC. " //In-App Free Subscription
@"1.GP", //GP = Gift Purchase
Expand Down Expand Up @@ -683,7 +695,9 @@ + (NSSet *)paidTransactionTypes {
@"F1", //Mac App
@"IA1", //In-App Purchase
@"IA9", //In-App Subscription
@"IA9-M", //In-App Subscription (Mac)
@"IAY", //In-App Auto-Renewable Subscription
@"IAY-M", //In-App Auto-Renewable Subscription (Mac)
@"FI1", //Mac In-App Purchase
@"IA1-M", //Mac In-App Purchase
@"1E", //Paid App (Custom iPhone)
Expand Down
2 changes: 1 addition & 1 deletion Classes/ReviewDownloadOperation.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ - (void)processReviewsPage:(NSDictionary *)reviewsPage {
}

NSDictionary *devResp = reviewData[@"developerResponse"];
if (devResp != nil) {
if (devResp != nil && devResp != (id)[NSNull null]) {
// Developer response was posted.
NSNumber *identifier = devResp[@"responseId"];
NSTimeInterval timeInterval = [devResp[@"lastModified"] doubleValue];
Expand Down