Skip to content

Commit 9e4701c

Browse files
committed
github: Update comment about NumPy pickle compatibility
1 parent d711f17 commit 9e4701c

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/run_unit_tests_oldest_deps.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ jobs:
4545
- name: Display installed dependency versions
4646
run: poetry run pip list
4747
- name: Run unit tests and code coverage
48-
# Skip test___pickled_value___unpickle___is_compatible because NumPy 2.0 broke pickle compatibility.
48+
# Skip test___pickled_value___unpickle___is_compatible because NumPy 2.0 does not support loading pickle files from NumPy 1.25 and earlier.
49+
# https://numpy.org/doc/2.0/numpy_2_0_migration_guide.html#note-about-pickled-files
4950
run: poetry run pytest ./tests/unit -v --cov=nitypes --junitxml=test_results/nitypes-oldest-deps-${{ matrix.os }}-py${{ matrix.python-version }}.xml -k "not test___pickled_value___unpickle___is_compatible"
5051
- name: Upload test results
5152
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0

0 commit comments

Comments
 (0)