Support custom listener ports#745
Conversation
sjberman
left a comment
There was a problem hiding this comment.
Looks good, can you do a manual test where we have multiple listeners without hostnames, on different ports, and then an HTTPRoute without a section name, and verify that we properly create a server for both ports with the HTTPRoute hostname, and traffic flows through either port?
This was a case I wanted to test when I implemented the empty section name work, but couldn't due to the port restriction.
Yep. Verified this works with multiple http & https listeners. |
3fd01f6 to
1bd0565
Compare
Co-authored-by: Michael Pleshakov <[email protected]>
Co-authored-by: Michael Pleshakov <[email protected]>
a7967d1 to
036bea5
Compare
Problem: NKG only supported listener ports 80 and 443. This limitation prevents the conformance tests from running because the conformance tests create a base Gateway that listens on port 8080. Solution: Allow users to specify any port between 1-65535.
Proposed changes
Problem: NKG only supported listener ports 80 and 443. This limitation prevents the conformance tests from running because the conformance tests create a base Gateway that listens on port 8080.
Solution: Allow users to specify any port between 1-65535.
Testing:
Closes #619
Checklist
Before creating a PR, run through this checklist and mark each as complete.