Allow resource allocation#2216
Merged
Merged
Conversation
sjberman
reviewed
Jul 10, 2024
anwbtom
force-pushed
the
feature/allow-resource-allocation
branch
from
July 11, 2024 07:26
6189db0 to
8fe094b
Compare
Contributor
|
@anwbtom can you run |
Contributor
Author
|
Thanks for the tip @kate-osborn, just ran the command and it only made a change in the readme of the chart. |
sjberman
approved these changes
Jul 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2216 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 96 96
Lines 6715 6715
Branches 50 50
=======================================
Hits 5884 5884
Misses 774 774
Partials 57 57 ☔ View full report in Codecov by Sentry. |
kate-osborn
approved these changes
Jul 12, 2024
sjberman
enabled auto-merge (squash)
July 15, 2024 14:06
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: When using autoscaling kubernetes clusters based on resource requests (like Karpenter implemenations or fargate kind of setups), pods will get evicted when the request 0 cpu and memory whilst the node it landed on is strapped for one of those resources, this change will give use the capability to set resource requests & limits in a way users see fit. Solution: Allow use to set resource values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: When using autoscaling kubernetes clusters based on resource requests (like Karpenter implemenations or fargate kind of setups), pods will get evicted when the request 0 cpu and memory whilst the node it landed on is strapped for one of those resources, this change will give use the capability to set resource requests & limits in a way users see fit.
Solution: Allow use to set resource values (https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#resource-requests-and-limits-of-pod-and-container)
Testing: Tested by overriding the default clusters and checking in k8s if resource settings where taken over.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.