Skip to content
This repository was archived by the owner on Oct 8, 2025. It is now read-only.

Conversation

@qdzlug
Copy link
Contributor

@qdzlug qdzlug commented Feb 11, 2022

Proposed changes

The original version of the repo-only IC deployment only allowed for NGINX Plus; this version allows for both versions of the NGINX controller - the standard OSS version or the Plus version. Documentation has been updated to reflect this change.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

feat: add ability to deploy NGINX IC or NGINX Plus IC from reg
@qdzlug qdzlug requested a review from dekobon February 11, 2022 22:11
@qdzlug qdzlug merged commit 8ce6f0a into nginxinc:master Feb 11, 2022
@qdzlug qdzlug deleted the nginxic branch February 11, 2022 23:32
@qdzlug qdzlug linked an issue Feb 15, 2022 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: can only deploy NGINX Plus IC with JWT in kubeconfig project

2 participants