-
Notifications
You must be signed in to change notification settings - Fork 148
Update dependency kubernetes-sigs/gateway-api-inference-extension to v1.2.0 #4361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update dependency kubernetes-sigs/gateway-api-inference-extension to v1.2.0 #4361
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4361 +/- ##
==========================================
+ Coverage 86.11% 86.13% +0.02%
==========================================
Files 132 132
Lines 14343 14343
Branches 35 35
==========================================
+ Hits 12352 12355 +3
+ Misses 1787 1785 -2
+ Partials 204 203 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shaun-nx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this one just until we can conform there are no breaking changes.
92f6911 to
16acacc
Compare
…v1.2.0 | datasource | package | from | to | | ----------- | ----------------------------------------------- | ------ | ------ | | github-tags | kubernetes-sigs/gateway-api-inference-extension | v1.1.0 | v1.2.0 | Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
16acacc to
a6df076
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
|
Took a look at the release notes, nothing appears to be breaking for us. |
|
I don't think we can run the new conformance test added though, kubernetes-sigs/gateway-api-inference-extension#1769, I applied the base files added here kubernetes-sigs/gateway-api-inference-extension@8fcbd8d#diff-1eb370261ae81ea093b13c60cfbca7665b37d1c3d83e91b06d4216aa8bfc7c21, and we invalidate the deployment because of multiple target ports on the inferencepool i think. And since these are the base yaml we cant comment out the test. Well actually failure to apply the base yaml might not make the test fail, but we should skip that test. |
|
@bjee19 Thanks for taking a look, I was hoping the pipeline would reveal the failures like this. I'm not seeing a Core or Extended designation for this. So I'm wondering if we need to implement that before we can say we support 1.2. In that case, this shouldn't be merged. |
sjberman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must fix failing test.
This PR contains the following updates:
v1.1.0->v1.2.0Release Notes
kubernetes-sigs/gateway-api-inference-extension (kubernetes-sigs/gateway-api-inference-extension)
v1.2.0Compare Source
What's Changed
stream_optionsvalue in Observability example by @aman4433 in #1758istioas aprovider-scoped value for the inferencepool Chart by @danehans in #1831New Contributors
Full Changelog: kubernetes-sigs/gateway-api-inference-extension@v1.1.0...v1.2.0
Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.