Skip to content

Commit c3905f6

Browse files
committed
Add additional feedback changes
1 parent 3925d3c commit c3905f6

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

internal/mode/static/nginx/config/servers_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -966,7 +966,7 @@ func TestCreateLocationsRootPath(t *testing.T) {
966966
for _, test := range tests {
967967
t.Run(test.name, func(t *testing.T) {
968968
locs := createLocations(test.pathRules, 80)
969-
g.Expect(locs).To(Equal(test.expLocations), fmt.Sprintf("test case: %s", test.name))
969+
g.Expect(locs).To(Equal(test.expLocations))
970970
})
971971
}
972972
}

internal/mode/static/state/graph/secret_test.go

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -189,14 +189,12 @@ func TestSecretResolver(t *testing.T) {
189189
g := NewWithT(t)
190190

191191
for _, test := range tests {
192-
t.Run(test.name, func(t *testing.T) {
193-
err := resolver.resolve(test.nsname)
194-
if test.expectedErrMsg == "" {
195-
g.Expect(err).To(BeNil(), fmt.Sprintf("case %q", test.name))
196-
} else {
197-
g.Expect(err).To(MatchError(test.expectedErrMsg), fmt.Sprintf("case %q", test.name))
198-
}
199-
})
192+
err := resolver.resolve(test.nsname)
193+
if test.expectedErrMsg == "" {
194+
g.Expect(err).To(BeNil(), fmt.Sprintf("case %q", test.name))
195+
} else {
196+
g.Expect(err).To(MatchError(test.expectedErrMsg), fmt.Sprintf("case %q", test.name))
197+
}
200198
}
201199

202200
expectedResolved := map[types.NamespacedName]*Secret{

0 commit comments

Comments
 (0)