Skip to content

Conversation

@sonukapoor
Copy link
Collaborator

Upgrade to Angular 20

@netlify
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for ngx-layout ready!

Name Link
🔨 Latest commit 2097e28
🔍 Latest deploy log https://app.netlify.com/projects/ngx-layout/deploys/686d124ff441d70008c0c427
😎 Deploy Preview https://deploy-preview-97--ngx-layout.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the workspace to Angular 20, updating dependencies, build configurations, and migration scripts to align with Angular 20 and NX 21 conventions.

  • Updated Angular, Material, CDK, and NX package versions in package.json
  • Switched TypeScript moduleResolution to bundler across tsconfig files
  • Added new migration definitions and applied API changes (e.g., TestBed.inject, provideServerRendering import, block control flow syntax)

Reviewed Changes

Copilot reviewed 27 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
projects/libs/**/tsconfig.*.json Consolidated arrays, set "moduleResolution": "bundler"
package.json Bumped Angular & NX versions to v20/v21, adjusted lint command
migrations.json Added migration entries for Angular 20 and NX 21, including document-core
projects/apps/updated-demo/src/app/components/custom-sidenav/custom-sidenav.component.ts Removed CommonModule from component imports (affects structural directives)
projects/apps/demo-app/src/app/responsive/responsive-row-column/component.html Converted *ngIf to new @if block control flow syntax
Comments suppressed due to low confidence (3)

migrations.json:12

  • This description is duplicated for the remove-custom-tasks-runner migration. Update it to accurately reflect removing the custom tasks runner configuration.
      "description": "Removes the legacy cache configuration from nx.json",

projects/apps/updated-demo/src/app/components/custom-sidenav/custom-sidenav.component.ts:71

  • CommonModule provides directives like *ngIf and *ngFor. Its removal will break template bindings; please re-add it to the imports array or ensure another module provides it.
    `,

package.json:110

  • [nitpick] TSLint is deprecated in the Angular ecosystem. Consider removing this dependency and migrating all linting to ESLint.
    "tslint": "^6.1.3",

@netlify
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for ngx-layout-docs failed.

Name Link
🔨 Latest commit 2097e28
🔍 Latest deploy log https://app.netlify.com/projects/ngx-layout-docs/deploys/686d124f2a07450008a862d6

@sonukapoor sonukapoor force-pushed the feature/upgrade-ng-20 branch from 1c10303 to 1e64aba Compare July 4, 2025 04:47
@sonukapoor sonukapoor had a problem deploying to FLEX_LAYOUT_BUILDS_TOKEN July 4, 2025 04:49 — with GitHub Actions Failure
@sonukapoor sonukapoor had a problem deploying to FLEX_LAYOUT_BUILDS_TOKEN July 4, 2025 05:04 — with GitHub Actions Failure
@sonukapoor sonukapoor force-pushed the feature/upgrade-ng-20 branch from acf6f97 to 7170d11 Compare July 4, 2025 05:07
@sonukapoor sonukapoor had a problem deploying to FLEX_LAYOUT_BUILDS_TOKEN July 4, 2025 05:09 — with GitHub Actions Failure
@sonukapoor sonukapoor force-pushed the feature/upgrade-ng-20 branch from 7170d11 to 5f9ff5e Compare July 4, 2025 05:11
@sonukapoor sonukapoor had a problem deploying to FLEX_LAYOUT_BUILDS_TOKEN July 4, 2025 05:13 — with GitHub Actions Failure
@sonukapoor sonukapoor force-pushed the feature/upgrade-ng-20 branch from 5f9ff5e to 72b2764 Compare July 4, 2025 05:18
@sonukapoor sonukapoor had a problem deploying to FLEX_LAYOUT_BUILDS_TOKEN July 4, 2025 05:20 — with GitHub Actions Failure
@sonukapoor sonukapoor force-pushed the feature/upgrade-ng-20 branch from 72b2764 to 2097e28 Compare July 8, 2025 12:42
Copy link
Contributor

@DuncanFaulkner DuncanFaulkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DuncanFaulkner DuncanFaulkner merged commit c453756 into ngbracket:main Jul 9, 2025
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants