-
-
Notifications
You must be signed in to change notification settings - Fork 16
feat: Upgrade to Angular 20 #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade to Angular 20 #97
Conversation
✅ Deploy Preview for ngx-layout ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the workspace to Angular 20, updating dependencies, build configurations, and migration scripts to align with Angular 20 and NX 21 conventions.
- Updated Angular, Material, CDK, and NX package versions in package.json
- Switched TypeScript
moduleResolutiontobundleracross tsconfig files - Added new migration definitions and applied API changes (e.g., TestBed.inject, provideServerRendering import, block control flow syntax)
Reviewed Changes
Copilot reviewed 27 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| projects/libs/**/tsconfig.*.json | Consolidated arrays, set "moduleResolution": "bundler" |
| package.json | Bumped Angular & NX versions to v20/v21, adjusted lint command |
| migrations.json | Added migration entries for Angular 20 and NX 21, including document-core |
| projects/apps/updated-demo/src/app/components/custom-sidenav/custom-sidenav.component.ts | Removed CommonModule from component imports (affects structural directives) |
| projects/apps/demo-app/src/app/responsive/responsive-row-column/component.html | Converted *ngIf to new @if block control flow syntax |
Comments suppressed due to low confidence (3)
migrations.json:12
- This description is duplicated for the
remove-custom-tasks-runnermigration. Update it to accurately reflect removing the custom tasks runner configuration.
"description": "Removes the legacy cache configuration from nx.json",
projects/apps/updated-demo/src/app/components/custom-sidenav/custom-sidenav.component.ts:71
- CommonModule provides directives like *ngIf and *ngFor. Its removal will break template bindings; please re-add it to the
importsarray or ensure another module provides it.
`,
package.json:110
- [nitpick] TSLint is deprecated in the Angular ecosystem. Consider removing this dependency and migrating all linting to ESLint.
"tslint": "^6.1.3",
❌ Deploy Preview for ngx-layout-docs failed.
|
1c10303 to
1e64aba
Compare
acf6f97 to
7170d11
Compare
7170d11 to
5f9ff5e
Compare
5f9ff5e to
72b2764
Compare
72b2764 to
2097e28
Compare
DuncanFaulkner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Upgrade to Angular 20