Skip to content

Commit e95bc1a

Browse files
committed
Improve handling of Node API properties
Signed-off-by: Louis Chemineau <louis@chmn.me>
1 parent a0a445c commit e95bc1a

5 files changed

Lines changed: 15 additions & 8 deletions

File tree

js/viewer-components.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/viewer-components.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/viewer-main.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/viewer-main.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/views/Viewer.vue

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1110,12 +1110,19 @@ export default {
11101110
},
11111111
11121112
// Update etag of updated file to break cache.
1113+
/**
1114+
*
1115+
* @param {Node} node
1116+
*/
11131117
async handleFileUpdated(node) {
11141118
const index = this.fileList.findIndex(({ fileid: currentFileId }) => currentFileId === node.fileid)
11151119
1116-
this.fileList.splice(index, 1, { ...node, etag: node.etag })
1120+
// Ensure compatibility with the legacy data model that the Viewer is using. (see "model.ts").
1121+
// This can be removed once Viewer is migrated to the new Node API.
1122+
node.etag = node.attributes.etag
1123+
this.fileList.splice(index, 1, node)
11171124
if (node.fileid === this.currentFile.fileid) {
1118-
this.currentFile.etag = node.etag
1125+
this.currentFile.etag = node.attributes.etag
11191126
}
11201127
},
11211128

0 commit comments

Comments
 (0)