Skip to content

Commit 69e536d

Browse files
authored
Merge pull request #4539 from nextcloud/bugfix/noid/prevent-delete-deadlock
2 parents 298ca57 + 5e92598 commit 69e536d

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

lib/Db/SessionMapper.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,13 @@ public function deleteInactiveWithoutSteps(?int $documentId = null): int {
111111
}
112112

113113
$qb = $this->db->getQueryBuilder();
114-
$qb->delete($this->getTableName())
115-
->where($qb->expr()->in('id', $qb->createFunction($selectSubQuery->getSQL())));
114+
$qb->delete($this->getTableName());
115+
if ($documentId !== null) {
116+
$qb->where($selectSubQuery->expr()->eq('document_id', $selectSubQuery->createParameter('documentId')));
117+
$qb->andWhere($qb->expr()->in('id', $qb->createFunction($selectSubQuery->getSQL())));
118+
} else {
119+
$qb->where($qb->expr()->in('id', $qb->createFunction($selectSubQuery->getSQL())));
120+
}
116121
$qb->setParameters([
117122
'lastContact' => time() - SessionService::SESSION_VALID_TIME,
118123
'documentId' => $documentId,

0 commit comments

Comments
 (0)