Skip to content

Commit 542ddbb

Browse files
committed
fix(cy): adjust selectors for filepicker
basename and extension are now split. Signed-off-by: Max <max@nextcloud.com>
1 parent 51b66dc commit 542ddbb

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

cypress/e2e/attachments.spec.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ describe('Test all attachment insertion methods', () => {
180180
cy.log('Go to sub folder (a)')
181181
cy.get('.file-picker__main .file-picker__file-name[title="sub"]').click()
182182
cy.get('.file-picker__main .file-picker__file-name[title="a"]').click()
183-
cy.get('.file-picker__main .file-picker__file-name[title="a.png"]').click()
183+
cy.get('.file-picker__main .file-picker__file-name[title="a"]').click()
184184

185185
cy.get('.dialog__actions button.button-vue--vue-primary').click()
186186

@@ -191,12 +191,13 @@ describe('Test all attachment insertion methods', () => {
191191
const requestAlias = 'insertPathRequest-b'
192192
cy.intercept({ method: 'POST', url: '**/filepath' }).as(requestAlias)
193193

194-
cy.log('Go back to sub folder')
195-
cy.get('#oc-dialog-filepicker-content .dirtree [data-dir="/sub"] a').click()
194+
cy.log('Go back from home to sub folder')
195+
cy.get('.file-picker__breadcrumbs a[title="Home"]').click()
196+
cy.get('.file-picker__main .file-picker__file-name[title="sub"]').click()
196197

197198
cy.log('Go to sub folder (b)')
198199
cy.get('.file-picker__main .file-picker__file-name[title="b"]').click()
199-
cy.get('.file-picker__main .file-picker__file-name[title="b.png"]').click()
200+
cy.get('.file-picker__main .file-picker__file-name[title="b"]').click()
200201

201202
cy.get('.dialog__actions button.button-vue--vue-primary').click()
202203

@@ -210,10 +211,10 @@ describe('Test all attachment insertion methods', () => {
210211
cy.intercept({ method: 'POST', url: '**/filepath' }).as(requestAlias)
211212

212213
cy.log('Go back to home')
213-
cy.get('#oc-dialog-filepicker-content .dirtree .crumb:first-child').click()
214+
cy.get('.file-picker__breadcrumbs a[title="Home"]').click()
214215

215216
cy.log('Select the file in the filepicker')
216-
cy.get('.file-picker__main .file-picker__file-name[title="github.png"]').click()
217+
cy.get('.file-picker__main .file-picker__file-name[title="github"]').click()
217218
cy.log('Click OK in the filepicker')
218219
cy.get('.dialog__actions button.button-vue--vue-primary').click()
219220

cypress/e2e/nodes/Links.spec.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,8 @@ describe('test link marks', function() {
139139
// Helper to reduce duplicated code, checking inserting with and without selected text
140140
const checkLinkFile = (filename, text) => {
141141
cy.getSubmenuEntry('insert-link', 'insert-link-file').click()
142-
cy.get(`.file-picker__main .file-picker__file-name[title="${filename}"]`).click()
142+
const basename = filename.replace(/(.*)\.[^\.]*/, '$1')
143+
cy.get(`.file-picker__main .file-picker__file-name[title="${basename}"]`).click()
143144
cy.get('.dialog__actions button.button-vue--vue-primary').click()
144145

145146
return cy.getContent()

0 commit comments

Comments
 (0)